CURA-12438 Add early-out for when no support is required #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12438 This avoids doing very long pre-calculations for support generation when the mesh actually has no single overhang
Contributor
Contributor
rburema
reviewed
Mar 4, 2025
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 8f186ca | Previous: 2d2e5f5 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
1.8689717619262927 ns/iter |
1.2447883898328285 ns/iter |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
rburema
approved these changes
Mar 4, 2025
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
LGTM, I left a project in the ticket that should demonstrate this well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids doing very long pre-calculations for support generation when the mesh actually has no single overhang
CURA-12438