CURA-12450 Flooring settings override bridging settings #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12450 This is done be de-registering flooring areas once the briding mask has been calculated, and registering them as being classic skin areas.
Contributor
rumboon
approved these changes
Mar 7, 2025
HellAholic
deleted the
CURA-12450_flooring-settings-override-bridging-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done be de-registering flooring areas once the briding mask has been calculated, and registering them as being classic skin areas.
This change feels a bit like band-aid though. Flooring areas are calculated very early, and bridging very lately. So we have to change the flooring areas afterwards, but before actually processing them. If the overall processing order changes, this could stop working.
CURA-12450