CURA-12474 set fixed 0 gap for brim support #2213
Conversation
CURA-12474 This requires having different starting outlines for models and supports, so that we don't apply the same gap for each
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: 9d06c92 | Previous: 6156738 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_slot_noplugin |
1.8890690113623052 ns/iter |
1.247252371095342 ns/iter |
1.51 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CURA-12474 by introducing a fixed zero gap for brim support, separating outlines for models versus supports. Key changes include replacing Shape with Outline in relevant functions, adjusting offset calculations for gapped versus touching outlines, and updating header declarations accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SkirtBrim.cpp | Updated logic in offset generation and first layer outline calculation using Outline |
| include/SkirtBrim.h | Updated declarations and structure definitions to support Outline usage |
This requires having different starting outlines for models and supports, so that we don't apply the same gap for each
CURA-12474