Skip to content

Conversation

@saumyaj3
Copy link
Contributor

CURA-11658

@saumyaj3 saumyaj3 marked this pull request as draft April 12, 2024 08:03
This update refines the cleanup process across different parts of the application. Node reset functionality has been introduced which thoroughly cleans up the memory. Clear functions within SettingOverrideDecorator, SceneNodeDecorator, ConvexHullDecorator and others are improved to completely cleanse after usage. This approach ensures a more efficient use and management of memory resources.

CURA-11658
@saumyaj3 saumyaj3 marked this pull request as ready for review April 17, 2024 07:55
only the set of operations within the specified range are deleted. This fine-tuned approach minimizes needless memory cleanups and enhances overall memory management.

CURA-11658
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark as for the other PR, I'm afraid of crashes, and I think methods naming is inconsistent.

The "clear" method has been renamed to "clearDecoratorData" to improve clarity on its function in several classes. This change affects the SettingOverrideDecorator, SceneNodeDecorator, ConvexHullDecorator, and SceneNode classes.

CURA-11658
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark as for Ultimaker/Cura#18883, still some reserve about this but I let you move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants