Skip to content

NP-250 Extract translations from intents file #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wawanbreton wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NP-250 Extract translations from intents file #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions recipes/translationextractor/all/conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def _extract_strings_to_pot_files(self) -> None:
self._extract_qml()
self._extract_plugin()
self._extract_settings()
self._extract_intents()

def _extract_source_files(self, prefix, extension_wildcard):
source_files = []
Expand Down Expand Up @@ -110,7 +111,7 @@ def _extract_plugin(self) -> None:
plugin_dict = json.loads(load(self._conanfile, path), object_pairs_hook=collections.OrderedDict)
if "name" not in plugin_dict or (
"api" not in plugin_dict and "supported_sdk_versions" not in plugin_dict) or "version" not in plugin_dict:
self._conanfile.output.warn(f"The plugin.json is invalid, ignoring it: {path}")
self._conanfile.output.warning(f"The plugin.json is invalid, ignoring it: {path}")
else:
if "description" in plugin_dict:
translation_entries += self._create_translation_entry("description", plugin_dict["description"])
Expand All @@ -121,9 +122,30 @@ def _extract_plugin(self) -> None:
if translation_entries:
save(self._conanfile, self._all_strings_pot_path, translation_entries, append=True)

def _extract_intents(self) -> None:
""" Extract the name and description from intents definition """
intents_json_path = Path(self._conanfile.source_folder, "resources", "intent", "intents.json")
if not intents_json_path.exists():
self._conanfile.output.info("No intents file found, skipping")
return

intents_dict = json.loads(load(self._conanfile, intents_json_path), object_pairs_hook=collections.OrderedDict)
translation_entries = ""

for intent_id in intents_dict:
intent_data = intents_dict[intent_id]
if "label" in intent_data:
translation_entries += self._create_named_translation_entry(intent_id, "intent label", intent_data["label"])
if "description" in intent_data:
translation_entries += self._create_named_translation_entry(intent_id, "intent description", intent_data["description"])

# Write intent name & description to output pot file
if translation_entries:
save(self._conanfile, self._all_strings_pot_path, translation_entries, append=True)

def _extract_settings(self) -> None:
""" Extract strings from settings json files to pot file with a matching name """
setting_json_paths = [path for path in self._conanfile.source_path.rglob("*.def.json") if "test" not in str(path)]
setting_json_paths = [path for path in Path(self._conanfile.source_folder).rglob("*.def.json") if "test" not in str(path)]
setting_json_data = []
for json_path in setting_json_paths:
setting_dict = json.loads(load(self._conanfile, json_path), object_pairs_hook = collections.OrderedDict)
Expand Down Expand Up @@ -187,23 +209,23 @@ def _process_settings(self, settings) -> str:

for name, value in settings.items():
if "label" in value:
translation_entries += self._create_setting_translation_entry(name, "label", value["label"])
translation_entries += self._create_named_translation_entry(name, "label", value["label"])
if "description" in value:
translation_entries += self._create_setting_translation_entry(name, "description", value["description"])
translation_entries += self._create_named_translation_entry(name, "description", value["description"])
if "warning_description" in value:
translation_entries += self._create_setting_translation_entry(name, "warning_description", value["warning_description"])
translation_entries += self._create_named_translation_entry(name, "warning_description", value["warning_description"])
if "error_description" in value:
translation_entries += self._create_setting_translation_entry(name, "error_description", value["error_description"])
translation_entries += self._create_named_translation_entry(name, "error_description", value["error_description"])
if "options" in value:
for item, description in value["options"].items():
translation_entries += self._create_setting_translation_entry(name, "option {0}".format(item), description)
translation_entries += self._create_named_translation_entry(name, "option {0}".format(item), description)
if "children" in value:
translation_entries += self._process_settings(value["children"])

return translation_entries

def _create_setting_translation_entry(self, setting: str, field: str, value: str) -> str:
return "msgctxt \"{0} {1}\"\nmsgid \"{2}\"\nmsgstr \"\"\n\n".format(setting, field, value.replace("\n", "\\n").replace("\"", "\\\""))
def _create_named_translation_entry(self, name: str, field: str, value: str) -> str:
return "msgctxt \"{0} {1}\"\nmsgid \"{2}\"\nmsgstr \"\"\n\n".format(name, field, value.replace("\n", "\\n").replace("\"", "\\\""))

def _create_translation_entry(self, field: str, value: str) -> str:
return "\nmsgctxt \"{0}\"\nmsgid \"{1}\"\nmsgstr \"\"\n".format(field, value.replace("\n", "\\n").replace("\"", "\\\""))
Expand Down Expand Up @@ -235,7 +257,7 @@ def _sanitize_pot_files(self) -> None:
for path in self._translations_root_path.rglob("*.pot"):
content = load(self._conanfile, path)
if "msgctxt" not in content:
self._conanfile.output.warn(f"Removing empty pot file: {path}")
self._conanfile.output.warning(f"Removing empty pot file: {path}")
rm(self._conanfile, path.name, path.parent)
else:
save(self._conanfile, path,
Expand Down