Added includes for the chrono library #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: Community Contribution 👑
Member
|
Thanks, we just noticed too. Sorry I didn't see this one before I fixed it. (See ccf276e) |
Author
|
No worries! I'd noticed there was an issue with the package workflow for our fork of Arcus a couple weeks ago but didn't get time to look into it a little until just yesterday as well, haha. Good to see it fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something appears to have changed in one of the more recent versions of MSVC and the Windows builds for Arcus broke. It seems that while Arcus was using the chrono library, Microsoft's compiler will no longer allow for implicit use of this library and requires that the include statement be present.
This change appears to fix the build errors and allows for a successful windows build.