CURA-12743 optimize painting performance #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12743
CURA-12743
CURA-12743
casperlamboo
approved these changes
Oct 2, 2025
casperlamboo
left a comment
casperlamboo
left a comment
There was a problem hiding this comment.
Approved, I do think the utility function in project.cpp could be moved to a dedicated utility file, but I do get that the added overhead of adding a header file etc is annoying.
Contributor
Author
In regard to the very limited scope of this library, this looks fine for now indeed. I have already put some code in geometric classes, so if we need similar code in other parts later, it can be done at that time. |
CURA-12743
CURA-12743
CURA-12743
…piler" This reverts commit 8b06a53.
CURA-12743 Apparently the MSVC compiler is more sensitive about forward-declaring a class or struct, but it doesn't say it explicitly...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the heavy calculation of projecting the paint stroke to the texture in C++ optimized code instead of Python, so that the painting is more user-friendly.
CURA-12743