Update tagging to add bead mode tags #29
Conversation
shirleydu
commented
Jan 13, 2025
shirleydu
commented
- Add new tags to map more closely to Cura's original tagging and what's available in accel/jerk settings.
- Have specific tags per extruder so that bead mode settings can be set for them separately.
- Keep the old tags so that Cloudprint can still preview the .makerbot files...
* Add new tags to map more closely to Cura's original tagging and what's available in accel/jerk settings. * Have specific tags per extruder so that bead mode settings can be set for them separately. * Keep the old tags so that Cloudprint can still preview the .makerbot files...
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 04dff78. ♻️ This comment has been updated with latest results. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Pause, // Command to allow for user defined pause. | ||
| }; | ||
|
|
||
| #define MB_BEAD_MODE_TAG(TAG_NAME) \ |
There was a problem hiding this comment.
function-like macro MB_BEAD_MODE_TAG used; consider a constexpr template function
| TAG_NAME##_0, \ | ||
| TAG_NAME##_1 | ||
|
|
||
| enum class Tag |
There was a problem hiding this comment.
enum Tag uses a larger base type (int, size: 4 bytes) than necessary for its value set, consider using std::uint8_t (1 byte) as the base type to reduce its size
| { CommandType::WaitForTemperature, "wait_for_temperature" }, | ||
| { CommandType::Pause, "pause" } }) | ||
|
|
||
| #define MB_JTP_TAG(TAG_NAME, TAG_STR) \ |
There was a problem hiding this comment.
function-like macro MB_JTP_TAG used; consider a constexpr template function
| #define MB_JTP_TAG(TAG_NAME, TAG_STR) \ | ||
| { Tag::TAG_NAME, #TAG_STR } | ||
|
|
||
| #define MB_BEAD_MODE_TAG_DEF(TAG_NAME, TAG_STR) \ |
There was a problem hiding this comment.
function-like macro MB_BEAD_MODE_TAG_DEF used; consider a constexpr template function
| MB_JTP_TAG(TAG_NAME##_1, TAG_STR##_1) | ||
|
|
||
| NLOHMANN_JSON_SERIALIZE_ENUM( | ||
| Tag, |
There was a problem hiding this comment.
no header providing "dulcificum::botcmd::Tag" is directly included
| } | ||
| } | ||
| else if (state.feature_type == "SKIN") | ||
| { |
There was a problem hiding this comment.
repeated branch body in conditional chain
|
I have made a quick test of these changes, I do see the new tags in the jsontoolpath file, however there are some paths tagged as |
|
@wawanbreton if you export gcode instead of a .makerbot file, does the gcode contain any tags for PRIME_TOWER_0? From what I understand, the tags in the jsontoolpath should match the tags assigned to the gcode. |
|
Oh, sorry, big mistake on my side. The prime-tower tag is indeed in the gcode, and there is actually a small prime tower because of the raft using a different material. So just forget what I said, all good 🙂 |
This reverts commit c515836.
This reverts commit c515836.
