Skip to content

Conversation

@saumyaj3
Copy link
Contributor

@saumyaj3 saumyaj3 commented Feb 6, 2025

NP-734

Ensure 'with_python_bindings' is safely accessed using 'get_safe' to prevent potential errors when the option is undefined during wsm build

NP-734
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 68bdcfe. ± Comparison against base commit 0225cb2.

♻️ This comment has been updated with latest results.

Copy link
Member

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HellAholic HellAholic merged commit 8351fcb into main Feb 10, 2025
8 checks passed
@HellAholic HellAholic deleted the NP-734-port-changes-to-conan-v2 branch February 10, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants