Trigger NPM package on PR against main: head_ref -> base_ref #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As no PR will be made on main (the condition for `head_ref` will always return false). Replaced with `base_ref` to check if the PR is against main instead.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the trigger condition for the npm package workflow to correctly check for pull requests targeting the main branch.
- Changed the pull_request trigger condition from comparing github.head_ref to 'main' to comparing github.base_ref to 'main'.
Comments suppressed due to low confidence (1)
.github/workflows/package.yml:37
- The updated condition now correctly checks github.base_ref for pull requests targeting the main branch. Please double-check that this change consistently meets the intended workflow trigger criteria for all relevant PR events.
if: ${{ (github.event_name == 'push' && (github.ref_name == 'main' || startsWith(github.ref_name, 'NP-'))) || (github.event_name == 'pull_request' && github.base_ref == 'main') }}
HellAholic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the trigger condition for the npm package on PRs against main:
head_ref (current branch) -> base_ref (target branch)