No longer rely on the presence of bash#605
Closed
ngaro wants to merge 1 commit into
Closed
Conversation
rusty-snake
reviewed
Feb 27, 2021
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| #!/bin/sh | |||
|
|
|||
Contributor
There was a problem hiding this comment.
The [[ below is not part of POSIX (https://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_04) and should be changed too IHMO.
This was referenced Feb 27, 2021
Closed
rusty-snake
approved these changes
May 2, 2021
rusty-snake
left a comment
rusty-snake
left a comment
Contributor
There was a problem hiding this comment.
Optional (to be full POSIX /bin/sh compliant):
-[[ $(id -u -n) != "root" ]]
+[ "$(id -u -n)" != "root" ]
Member
|
I will merge this first, then #608. Therefore, it shouldn't be a problem. Or did I miss something? Thank you for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although bash is available in most distributions, this is not always the case.
A notable example are docker containers based on Alpine linux it's more often missing than present.
This PR makes sure it works everywhere by relying on a shell instead of a specific shell.
The FHS defines that if the system has shells (1 or more), at least one of them should be in
/bin. So the forced location is not a problem.The script itself doesn't need any change, it always does exactly the same. It doesn't matter if you use bash, zsh, csh or even busybox.