Skip to content

fix: remove Agent upgrade validation from the upgrade firmware flow #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kareltucek merged 1 commit into from
Dec 15, 2025
Merged

fix: remove Agent upgrade validation from the upgrade firmware flow #2780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/uhk-agent/src/services/device.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import {
RIGHT_HALF_FIRMWARE_UPGRADE_MODULE_NAME,
RightSlotModules,
SaveUserConfigurationData,
shouldUpgradeAgent,
shouldUpgradeFirmware,
simulateInvalidUserConfigError,
UHK_80_DEVICE,
Expand Down Expand Up @@ -511,12 +510,6 @@ export class DeviceService {

uhkDeviceProduct = await getCurrentUhkDeviceProduct(this.options);
checkFirmwareAndDeviceCompatibility(packageJson, uhkDeviceProduct);
if (shouldUpgradeAgent(packageJson.userConfigVersion, this.disableAgentUpgrade)) {
response.failReason = FirmwareUpgradeFailReason.UserConfigVersionNotSupported;
this.logService.error(`[DeviceService] The firmware contains ${packageJson.userConfigVersion} user config version, which is newer than ${VERSIONS.userConfigVersion} which this Agent supports. Minor version check is used.`);

return event.sender.send(IpcEvents.device.updateFirmwareReply, response);
}

let dongleHid = await getCurrentUhkDongleHID();
if (dongleHid) {
Expand Down