prepare projectM cwrapper for 64-bit#1220
Merged
Merged
Conversation
Contributor
Author
|
As requested by @s09bQ5 |
s09bQ5
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UltraStar-Deluxe/mxe#2 requires some updates to the projectM cwrapper to be able to build 64-bit compatible dlls for windows:
The issue was that the wrapper did not define its own ABI explicitly: it relied on an external
DLLEXPORTmacro for symbol export, and its function definitions relied on the compiler’s default calling convention instead of statingcdeclexplicitly. On Windows, where calling convention is part of the ABI, that can lead to compatibility problems for Pascal callers.The change was to define the wrapper ABI locally via
PROJECTM_CWRAPPER_APIandPROJECTM_CWRAPPER_CALL, and apply those macros to all exported declarations and definitions so symbol export and calling convention are explicit and work on every platform.