Remove stale outdated game language template scripts#1328
Open
dgruss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
game/languages/Language.newgame/languages/update.pygame/languages/convert.shgame/languages/README.mdto documentEnglish.inias the translation templateReasoning
Language.newis an outdated duplicate of the English translation file. Keeping it requires developers to remember to update two translation templates, and when that does not happen translators can start from stale or incomplete strings.English.iniis already the canonical source for game translation keys and fallback text, so using it directly as the template removes that synchronization problem. This makes the translation workflow simpler: copyEnglish.ini, rename it to the target language, translate values, and keep the same keys.The removed
update.pyscript was part of the oldLanguage.newworkflow and is not documented as a reliable maintenance step. Besides lacking documentation, the behavior was also unintuitive. Since it can rewrite translation files, keeping it around makes the process look supported even though the intended path is nowEnglish.ini.The removed
convert.shscript was only tied to legacy language-file conversion and it was not clear when or by whom it should be used. Removing it avoids leaving another stale maintenance path beside the deleted template/update script.Fixes #524.