-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition for lower and upper Dedekind reals #1342
Addition for lower and upper Dedekind reals #1342
Conversation
Co-authored-by: Vojtěch Štěpančík <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go aside from the comment on *polymorphism. 👍
We can either be forced to generalize the additive identity to every universe level, or stick with this as-is. (This comes back to the problems associated with #1334 .) We can do that, if we want. Setting up an additive inverse for every level at least lets us use small groups on every universe level. Is that your preference? |
Ahh, shoot, that's a bummer. Then I think it is better to leave it as is for now. We shouldn't formalize "raise" operations on real numbers just to get this half-way polymorphism. If we really need polymorphism then the appropriate way to go would be to find the correct definition of a "large monoid" and so on, and since that is an open question for the time being, let's keep it like it is. |
FWIW, large monoids are probably reasonably easy; it's groups where it gets really hard. We can have those if you like. |
Depends on #1339, but adds ~500LOC beyond that, and seems like a reasonable sub-PR to break away from #1336 .