-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequences of positive rational numbers #1371
base: master
Are you sure you want to change the base?
Sequences of positive rational numbers #1371
Conversation
src/elementary-number-theory/positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
This reverts commit 1576dd8. I don't know why the link is broken, but this didn't fix it.
Hi @fredrik-bakke! I hope you are doing well. The next steps would probably be to work with geometric series, if we prove PS: I have no idea why the link-check doesn't pass. Do you have any tip? Also, the typechecking seems a bit long; I guess we'll have to |
"Concept definition not found: arithmetic sequence ; expected "arithmetic-sequence-ℚ⁺" to exist in elementary-number-theory.arithmetic-sequences-positive-rational-numbers.md" means that there's an issue with the
Unless you really need to calculate with the definition, probably at least proofs of inequalities should be abstract |
oh! I see. sorry, you could have caught that!
ok. I'll do that. thanks a lot! |
src/elementary-number-theory/geometric-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/arithmetic-sequences-positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/positive-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice pull request, and welcome back!
I've attempted to give a proper review of this PR, but seeing as I'm one of the people least involved with elementary number theory, it might make sense in the future to defer some of the review work to @lowasser if he's comfortable with that, or @EgbertRijke given that he has time.
…ional-numbers.lagda.md Co-authored-by: Fredrik Bakke <[email protected]>
…ional-numbers.lagda.md Co-authored-by: Fredrik Bakke <[email protected]>
Hello. Thanks for your feedback. I'll mark this as a draft while I address your comments and re-open it when I have a cleaner version. |
I rewrote the definitions of arithmetic and geometric sequences as arithmetic sequences in semigroups. These are the sequences with a constant difference between successive terms. I think it's more in the spirit of what you expected. All the ingredients are here to prove |
Yes, I saw, that's a great solution!
Yes, that sounds good. This PR is already getting somewhat large. |
This PR implements some of my suggestions from #1354 (comment)
It introduces the following modules:
group-theory.arithmetic-sequences-semigroups
:uₙ₊₁ = uₙ + d
;elementary-number-theory.arithmetic-sequences-positive-rational-numbers
:uₙ = u₀ + n d
;elementary-number-theory.geometric-sequences-positive-rational-numbers
:uₙ = u₀ rⁿ
;elementary-number-theory.bernoullis-inequality-positive-rational-numbers
:∀ (h : ℚ⁺) (n : ℕ) → 1 + (n + 1)h ≤ (1 + n h)(1 + h)
;∀ (h : ℚ⁺) (n : ℕ) → 1 + n h ≤ (1 + h)ⁿ
.