Add universal search screen with classic search toggle#1533
Open
obiwantoby wants to merge 1 commit intoUnicornsOnLSD:redesignfrom
Open
Add universal search screen with classic search toggle#1533obiwantoby wants to merge 1 commit intoUnicornsOnLSD:redesignfrom
obiwantoby wants to merge 1 commit intoUnicornsOnLSD:redesignfrom
Conversation
- Add UniversalSearchScreen with debounced Jellyfin API search across Audio, Albums, Artists, Playlists, and Genres - Use TrackListTile and ItemCollectionWrapper for rich search results - Add useUniversalSearch setting (HiveField 144) with Layout Settings toggle - Route search icon and drawer to universal or classic search based on setting - Fix iOS 26 crash: add FLTEnableTouchRateCorrection=false to all plists - Fix iOS file_picker FileUtils class collision via Podfile preprocessor rename - Bump file_picker to ^10.3.10 Closes UnicornsOnLSD#471
Collaborator
|
Thanks for the (new) PR! Some more things you might want to consider:
This is just a **rough** mockup, and somewhat outdated. Don't mind how the item tiles look, don't mind the dark mode, don't mind the colors. The important bit would be the tabs / item types to search in, which can be toggled on and off. It would also be good if were obvious which kind of item is being shown.
|
Collaborator
|
@obiwantoby are you planning to make any further changes here? If not, I'll have to close the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
TrackListTilefor audio items andItemCollectionWrapperfor albums/artists/playlists to maintain consistency with existing app UIuseUniversalSearchsetting (HiveField 144) with a toggle in Layout & Theme settings. Users can switch back to the in-page classic search if preferredFLTEnableTouchRateCorrection=falseto Debug, Release, and Profile plists to resolve VSyncClient crash on iOS 26 devicesFileUtils→FPFileUtilsto resolve class collision with OSAnalytics frameworkTodo before merging
Related Issues
Note this did fix an inappropriate pull request to which some other dart code was removed.