Skip to content

Use dependency group for dev dependencies #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Apr 1, 2025

Scope and purpose

This moves dev dependencies out of [project.optional-dependencies] and into [dependency-groups]. Now we just need to wait for tooling support. See PEP 735.

Less important:

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/changed documentation
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@hmpf hmpf added the blocked Another thing/issue has to be resolved before tackling this label Apr 1, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in HTMXify Argus Apr 1, 2025
@hmpf
Copy link
Contributor Author

hmpf commented Apr 1, 2025

After tooling support is in, we need to update tox/docs.

Copy link

github-actions bot commented Apr 1, 2025

Test results

    4 files    476 suites   21m 5s ⏱️
  578 tests   577 ✅ 1 💤 0 ❌
2 312 runs  2 308 ✅ 4 💤 0 ❌

Results for commit 87e1f74.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.56%. Comparing base (7cbcc9f) to head (87e1f74).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         142      142           
  Lines        5883     5883           
=======================================
  Hits         4622     4622           
  Misses       1261     1261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmpf hmpf force-pushed the dependency-groups branch from d18dc62 to ebd6d7d Compare April 22, 2025 09:14
@hmpf hmpf force-pushed the dependency-groups branch from ebd6d7d to 99ad1e7 Compare May 14, 2025 06:05
@hmpf hmpf moved this from 📋 Backlog to 🏗 In progress in HTMXify Argus May 14, 2025
@hmpf hmpf self-assigned this May 14, 2025
@hmpf hmpf force-pushed the dependency-groups branch from 99ad1e7 to 87e1f74 Compare May 16, 2025 11:17
Copy link

@hmpf hmpf added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Another thing/issue has to be resolved before tackling this nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) priority: low
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants