Add filter scope preview to planned maintenance form by Simrayz · Pull Request #1770 · Uninett/Argus

Simrayz · 2026-01-26T10:34:01Z

Scope and purpose

Resolves #1765

This PR adds a preview of incidents that are covered by the currently selected filters in the Planned Maintenance form.
This should give a good indication of the extent of the maintenance task, to avoid accidentally generating too many notifications.

Screenshots

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

Added a changelog fragment for towncrier
Added/amended tests for new/changed code
Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
Linted/formatted the code with ruff and djLint, easiest by using pre-commit
The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
If this results in changes in the UI: Added screenshots of the before and after
If this results in changes to the database model: Updated the ER diagram

github-actions · 2026-01-26T10:37:19Z

Test results

6 files 894 suites 1m 50s ⏱️
704 tests 703 ✅ 1 💤 0 ❌
4 224 runs 4 218 ✅ 6 💤 0 ❌

Results for commit 5907b9f.

♻️ This comment has been updated with latest results.

codecov · 2026-01-26T10:37:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (8f8a393) to head (5907b9f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   82.57%   82.69%   +0.12%     
==========================================
  Files         137      137              
  Lines        6552     6577      +25     
==========================================
+ Hits         5410     5439      +29     
+ Misses       1142     1138       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hmpf · 2026-02-17T09:42:09Z

Please mention somewhere close by the "Filters" box that it is necessary to type at least two letters, I thought something was broken for a second there...

hmpf · 2026-02-17T09:49:25Z

Also, it seems it is not possible to control the column layout in the preview via user preferences, and the layout used isn't any of the ones defined locally on my dev-box. Should we add another built in, or alter the "on maintenance"-one? It's what it's for.

If the layout is hard-coded it should use one that can also be used in the dashboard (we could just show the name somewhere on the pm page) or I can guarantee you we will get support-requests ala. "how can I use the layout from the pm page for the dashboard".

hmpf

See the comments.

hmpf · 2026-02-17T09:56:37Z

src/argus/htmx/plannedmaintenance/views.py

 from argus.util.datetime_utils import LOCAL_INFINITY

 FLATPICKR_DATETIME_FORMAT = "%Y-%m-%d %H:%M"
+FILTER_PREVIEW_COLUMNS = ["start_time", "level", "source_type", "source", "description", "tags"]


Don't hardcode this here.

These are the columns that I feel are necessary to identify and compare incidents in a meaningful way. There is no existing column preset that gives enough information (such as on maintenance)

The hardcoded column list has been removed. I extended the "on maintenance" column preset instead, and added a new constant to point to the maintenance column preset name.

hmpf · 2026-02-17T10:01:57Z

src/argus/htmx/plannedmaintenance/views.py

+    open_incidents = Incident.objects.open()
+    total_open = open_incidents.count()


What if nothing is open? There might be a procedure "manually mark as closed when seen".

Added handling of the case where there are no open incidents, which will show a message to the user instead of "Covers 0 open incidents"

hmpf · 2026-02-17T10:14:59Z

src/argus/htmx/templates/htmx/plannedmaintenance/plannedmaintenance_form.html

+
+    // Filter preview functionality
+    (() => {
+      const filterPreview = document.getElementById('filter-preview');
+      const filtersSelect = document.getElementById('id_filters');
+      if (!filterPreview || !filtersSelect) return;
+
+      const previewUrl = '{% url "htmx:plannedmaintenance-filter-preview" %}';


Suggestion: would it work to put large scripts like this in a fragment (say, _plannedmaintenance_form.js as a sibling of plannedmaintenace_form.html) and {% include %} it?

Or would that make for a bigger maintenance burden.

Fair point, it doesn't really have a high maintenance burden as long as they are co-located.

Simrayz · 2026-02-17T14:38:11Z

Please mention somewhere close by the "Filters" box that it is necessary to type at least two letters, I thought something was broken for a second there...

Added to the description below the search input. The combobox has the same behaviour as on the front page, requiring at least two characters to search.

sonarqubecloud · 2026-02-17T14:49:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Simrayz added HTMx Views, urls, templates... frontend Affects frontend planned maintenance labels Jan 26, 2026

Simrayz self-assigned this Jan 26, 2026

Simrayz requested a review from a team January 26, 2026 10:34

Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch 2 times, most recently from 36163ff to 9e96035 Compare January 26, 2026 12:27

Simrayz mentioned this pull request Jan 26, 2026

Add "under maintenance" column to maintenance column preset #1775

Merged

8 tasks

Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch from 9e96035 to c6d2050 Compare February 16, 2026 11:09

Simrayz marked this pull request as ready for review February 16, 2026 11:10

Simrayz mentioned this pull request Feb 16, 2026

Add staff access control to search_filters and filter_preview endpoints #1784

Open

Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch 2 times, most recently from cf09123 to fc2e571 Compare February 16, 2026 13:02

hmpf reviewed Feb 17, 2026

View reviewed changes

hmpf requested a review from a team February 17, 2026 09:51

hmpf reviewed Feb 17, 2026

View reviewed changes

hmpf requested a review from a team February 17, 2026 10:16

Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch 2 times, most recently from 2591ea9 to 450c458 Compare February 17, 2026 14:31

Simrayz added 4 commits February 17, 2026 15:39

Add filter scope preview to planned maintenance form

d8b7533

Add test coverage for filter preview

580baf9

Extract inline script to co-located template partial

6a285fe

Handle no open incidents in filter preview

da3e401

Use maintenance column layout preset in filter preview

5907b9f

Simrayz force-pushed the feat/1765-add-preview-of-the-scope-of-filters-attached-to-a-pm-task branch from 450c458 to 5907b9f Compare February 17, 2026 14:48

Simrayz requested a review from hmpf February 17, 2026 17:17

		open_incidents = Incident.objects.open()
		total_open = open_incidents.count()

Conversation

Simrayz commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope and purpose

Screenshots

Contributor Checklist

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test results

Uh oh!

codecov bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hmpf commented Feb 17, 2026

Uh oh!

hmpf commented Feb 17, 2026

Uh oh!

hmpf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hmpf Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Simrayz Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Simrayz Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

hmpf Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Simrayz Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

hmpf Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Simrayz Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Simrayz commented Feb 17, 2026

Uh oh!

sonarqubecloud bot commented Feb 17, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Simrayz commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

codecov bot commented Jan 26, 2026 •

edited

Loading

hmpf left a comment •

edited

Loading