Skip to content

Ensure Apprise is installed when Apprise-derived media are activated#2003

Open
aleksfl wants to merge 1 commit into
mainfrom
set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed
Open

Ensure Apprise is installed when Apprise-derived media are activated#2003
aleksfl wants to merge 1 commit into
mainfrom
set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed

Conversation

@aleksfl

@aleksfl aleksfl commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Scope and purpose

Fixes #1965.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to

@aleksfl
aleksfl requested a review from a team July 7, 2026 11:16
@aleksfl aleksfl self-assigned this Jul 7, 2026
@aleksfl aleksfl added notification Affects the notification system apprise Dependent on the 3rd party dependency apprise, used for sending notifications. labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Test results

    8 files  1 768 suites   3m 39s ⏱️
  983 tests   982 ✅ 1 💤 0 ❌
7 864 runs  7 856 ✅ 8 💤 0 ❌

Results for commit 65216ae.

♻️ This comment has been updated with latest results.

@aleksfl aleksfl changed the title Ensure Apprise mediums installed is marked correctly Ensure Apprise-derived medium installed is marked correctly Jul 7, 2026
@aleksfl
aleksfl force-pushed the set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed branch from 90c2d34 to 0356f22 Compare July 7, 2026 13:42
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (c5ebd83) to head (65216ae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   88.86%   88.94%   +0.07%     
==========================================
  Files         152      152              
  Lines        7283     7289       +6     
==========================================
+ Hits         6472     6483      +11     
+ Misses        811      806       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksfl aleksfl changed the title Ensure Apprise-derived medium installed is marked correctly Ensure Apprise-derived media installed is marked correctly Jul 7, 2026
@aleksfl
aleksfl force-pushed the set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed branch 2 times, most recently from d841faf to 6c2e2c4 Compare July 7, 2026 14:03
@johannaengland

Copy link
Copy Markdown
Contributor

Could you talk me through why your adding the is_available function? Is it not possible to update the is_installed field when Apprise is not installed?
Because now we're adding another layer of logic to the already complicated destinations

@aleksfl
aleksfl force-pushed the set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed branch from 6c2e2c4 to e38fde7 Compare July 9, 2026 10:53
@aleksfl aleksfl changed the title Ensure Apprise-derived media installed is marked correctly Ensure Apprise is installed when Apprise-derived media are activated Jul 9, 2026
@aleksfl

aleksfl commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Could you talk me through why your adding the is_available function? Is it not possible to update the is_installed field when Apprise is not installed? Because now we're adding another layer of logic to the already complicated destinations

Reworking to simply check on startup as discussed in the PR meeting.

@aleksfl

aleksfl commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Sticking with a mocked Apprise for the tests to stay within the scope of this issue, but for the future the tests should be reworked and expanded to use the real Apprise library for maximum coverage.

@aleksfl
aleksfl force-pushed the set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed branch 5 times, most recently from 983763a to 4957086 Compare July 10, 2026 13:57
@aleksfl
aleksfl force-pushed the set-mediainstalled-field-to-false-for-media-that-are-derived-from-apprise-if-that-dependency-is-not-installed branch from 4957086 to 65216ae Compare July 10, 2026 13:58
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apprise Dependent on the 3rd party dependency apprise, used for sending notifications. notification Affects the notification system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set Media.installed field to false for media that are derived from Apprise if that dependency is not installed

2 participants