github is really stupid for this.#8
Merged
veeeanti merged 1 commit intoMay 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I had to push my changes I had made to my fork of this on my personal account, which is REALLY stupid since I am the original creator of both the repo AND the organization. Why it wouldn't let me is beyond me, I suspect it has something to do with me using the Linux version of Github Desktop and git (seeing as how it just wouldn't let me login on the terminal (I KNOW WHAT MY PASSWORD IS, GIT, ACCEPT IT!!!)) but anyways, this works just fine for me.
This is a "refactor", I hope I used that term correctly, of the last working version / release of uc-online2 that I found to be operational, which is
v1.2.0. Somewhere along the line, I broke a lot of things and tried fixing it with duct tape. AFTER I had already shot at it twice with a shotgun at point blank range.
Even though some people had said they got it to work, I was never able to actually run any games with it. Yeah, sure, I got Steam to initialize with the set AppId, but the game never ran.
I'm going back on splitting the .dll into two, that was probably a big factor in this huge mess and I can look more into it and better execute that when and if I work on uc-online3. I apologize for the inconvenience I have caused the people who have been using this, I know it's annoying when things just don't work like they should or are claimed to.
I also took all of @xinerqu's changes and additions from PR #6 and added them in. Again, thank you for helping figure these things out. This should 100% work now or at least semi-work for anything it can be used with.