docs(playbook): capture the trading-api serving gate + dep-bump lessons - #373
Open
codyborn wants to merge 3 commits into
Open
docs(playbook): capture the trading-api serving gate + dep-bump lessons#373codyborn wants to merge 3 commits into
codyborn wants to merge 3 commits into
Conversation
The Robinhood/Arc rollout shipped V3 fully wired yet serving zero RFQs because the UNISWAPX_V3_ROLLOUT_CHAINS serving gate (separate from the CHAIN_INFO_MAP DUTCH_V3 override) was missed. Update NEW_CHAIN.md so the next chain doesn't repeat it: - §3.6 rewritten to current trading-api reality: the TWO independent gates (construction via CHAIN_INFO_MAP, serving via UNISWAPX_V3_ROLLOUT_CHAINS), and removal of stale symbols (UNISWAPX_SUPPORTED_CHAIN_IDS, GAS_COMPARISON_MULTIPLIER_BY_CHAIN, V3_BLOCK_LENGTH_BY_CHAIN, disable_uniswapx_<chain>) that no longer exist. - Correction G: the two-gate trap + RFQ-requestId/APM debugging notes. - Correction H: downstream sdk-core / uniswapx-sdk pins must be bumped (published != consumed); release-versioning ordering. - Correction I: Corrections C and D are stale (param-api/x-service refactored). - §6: Robinhood/Arc reference-diff PR table (incl. the two trading-api PRs). - §7: end-to-end checklist with both gates called out. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The deployments page (Uniswap/docs, developers.uniswap.org) is an external artifact the rollout never tracked. Add it as a Phase 4 launch step and a §7 checklist item, and record the Robinhood/Arc docs PR (Uniswap/docs#1136) in the §6 reference table. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
alanhwu
previously approved these changes
Jun 25, 2026
- Correct the Arc constant-basefee assumption: Arc's USDC-denominated base fee is dynamic (EWMA EIP-1559, floor 20 gwei), not fixed — it just sits at the floor when idle. Removed from CONSTANT_BASE_FEE_CHAINS (backend#9642). Update §3.6 + arc.md, and warn future rollouts to confirm fee design from docs, not a quiet-window probe. - Update the docs-site step: the UniswapX deployments page moved from Uniswap/docs to the Universe repo (apps/dev-portal/.../uniswapx/deployments.mdx). Case-study table points at universe#34819 (old docs#1136 closed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Robinhood/Arc rollout deployed every repo — reactors, SDK, param-api, x-service, and trading-api's
CHAIN_INFO_MAPDUTCH_V3override — and RFQ still never fired, silently, because trading-api's second gate (UNISWAPX_V3_ROLLOUT_CHAINS, the serving allowlist) was missed. The playbook didn't mention that gate and had drifted from the real code. This updates it so the next chain can't repeat the miss.Changes to
playbook/NEW_CHAIN.mdCHAIN_INFO_MAPDUTCH_V3override; serving =UNISWAPX_V3_ROLLOUT_CHAINS), and removal of stale symbols that no longer exist (UNISWAPX_SUPPORTED_CHAIN_IDS,GAS_COMPARISON_MULTIPLIER_BY_CHAIN,V3_BLOCK_LENGTH_BY_CHAIN, per-chaindisable_uniswapx_<chain>). Notes the now-generic bits (block length, gas comparison, RFQ protocol mapping).trading/goudaserviceare APM/own-pipeline, not the default indexed log view.sdk-core7.14.0 whereChainId.ROBINHOODwas the testnet id). Plus release-version ordering.SUPPORTED_CHAINSsource, global retry floor).main" set), including both trading-api PRs (#9599 wired it, #9615 served it).Docs-only.
🤖 Generated with Claude Code