Skip to content

tests - #123

Closed
wkoutre wants to merge 28 commits into
mainfrom
dgilman/package-fixes
Closed

tests#123
wkoutre wants to merge 28 commits into
mainfrom
dgilman/package-fixes

Conversation

@wkoutre

@wkoutre wkoutre commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

No description provided.

wkoutre and others added 28 commits October 9, 2025 13:47
- Updated README.md to recommend sonnet-4.5 as the preferred model for new agents.
- Changed model references in commit-message-generator.md and pr-creator.md to sonnet-4.5.
- Modified schema.d.ts and schema.json to include sonnet-4.5 as an option for agent models.
- Updated README.md to recommend sonnet-4.5 as the preferred model for new agents.
- Changed model references in commit-message-generator.md and pr-creator.md to sonnet-4.5.
- Modified schema.d.ts and schema.json to include sonnet-4.5 as an option for agent models.
- project: @uniswap/ai-toolkit-nx-claude 0.5.10-next.0

- project: @ai-toolkit/utils 0.2.10-next.0

- project: @ai-toolkit/agents-agnostic 0.2.10-next.0

- project: @ai-toolkit/commands-agnostic 0.1.14-next.0

- project: @ai-toolkit/commands-typescript 0.1.11-next.0
- Updated README.md to recommend sonnet-4.5 as the preferred model for new agents.
- Changed model references in commit-message-generator.md and pr-creator.md to sonnet-4.5.
- Modified schema.d.ts and schema.json to include sonnet-4.5 as an option for agent models.
- project: @uniswap/ai-toolkit-nx-claude 0.5.10-next.1

- project: @ai-toolkit/utils 0.2.10-next.1

- project: @ai-toolkit/agents-agnostic 0.2.10-next.1

- project: @ai-toolkit/commands-agnostic 0.1.14-next.1

- project: @ai-toolkit/commands-typescript 0.1.11-next.1
#73)

* Improve the claude docs agents by adding a fact-checker subagent that verifies the output of other claude doc agents

Completes DEV-107

sub-commits:

add initial plan

implement plan for updating claude-docs to use fact-checker and batched approvals

* add model prompt parameter to several subagents
- project: @uniswap/ai-toolkit-nx-claude 0.5.10-next.2

- project: @ai-toolkit/utils 0.2.10-next.2

- project: @ai-toolkit/agents-agnostic 0.2.10-next.2

- project: @ai-toolkit/commands-agnostic 0.1.14-next.2

- project: @ai-toolkit/commands-typescript 0.1.11-next.2
…mation for git commits at logical completion points (#72)

* improvement: update execute-plan documentation to require user confirmation for git commits at logical completion points

* improvement: require user confirmation before creating git commits in various workflows
…timize deployment process (#75)

### TL;DR

Added an ignore command to the Vercel configuration for the Slack OAuth backend to skip deployments when the project is not affected.

### What changed?

Added an `ignoreCommand` to the `vercel.json` file that uses the Nx affected projects detection to determine if the `slack-oauth-backend` project was modified between the previous and current commit. If the project wasn't affected, the deployment will be skipped.

### How to test?

1. Make a change to a different project in the monorepo
2. Verify that the Slack OAuth backend doesn't deploy on Vercel
3. Make a change to the Slack OAuth backend
4. Verify that the deployment proceeds as expected

### Why make this change?

This optimization prevents unnecessary deployments of the Slack OAuth backend when changes are made to unrelated parts of the codebase. This will save deployment resources and time by only triggering deployments when the project is actually affected by changes.
… Slack notifications (#76)

### Summary of Changes
- Updated the production update workflow to generate a categorized changelog based on commit types (features, fixes, documentation, maintenance, and others).
- Added Slack notifications for both successful PR creation and merge conflicts.
- Improved workflow documentation to clarify required secrets and behavior.
- Assigned specific reviewers to the PR and included detailed next steps in the summary.

### Why This Change?
These enhancements streamline the release process, improve communication with the team, and ensure that the changelog is informative and well-structured for easier review.
### Summary of Changes
- Replaced single quotes with double quotes for consistency in the `publish-packages.yml` file.
- Removed the NPM authentication verification step that was conditional on the dry run input.

### Why This Change?
These adjustments improve the readability of the workflow file and streamline the publishing process by eliminating unnecessary checks.
…78)

### Summary of Changes
- Deleted `always-auth` and `_authToken` entries from `.npmrc`.
- Removed `NODE_AUTH_TOKEN` references from the GitHub Actions workflow and documentation.

### Why This Change?
These modifications streamline the configuration by eliminating unnecessary authentication steps, enhancing clarity and security in the publishing process.
…ion flow (#71)

* feat: enhance addon installation process and conditional prompting

- Added support for installing all MCP servers at once or a specific one via new `installMode` option.
- Updated generator logic to handle installation modes and provide detailed installation summaries.
- Introduced critical rules for conditional prompting in Nx generator schemas to improve user experience.
- Expanded addon registry with new MCP servers including Graphite, Nx, Slack, and others.
- Enhanced documentation for MCP authentication instructions and setup guidance.

* get notion mcp addon working

This required changing the AddonMetadata interface to support a new non-command based way of adding mcps to claude

---------

Co-authored-by: Melvillian <alex.melville@uniswap.org>
### TL;DR

Updated MCP configuration for Figma and Vercel addons to use the new transport/url pattern.

### What changed?

Modified the addon registry configuration for Figma and Vercel addons:
- Renamed `command` to `transport` in both addon configurations
- Renamed `args` array to `url` string property
- Preserved the actual transport types and URLs

### How to test?

1. Verify that the Figma addon connects properly using SSE transport to `http://127.0.0.1:3845/mcp`
2. Verify that the Vercel addon connects properly using HTTP transport to `https://mcp.vercel.com`

### Why make this change?

This change standardizes the MCP configuration pattern by using more descriptive property names (`transport` instead of `command`, `url` instead of an array of arguments). This improves code readability and makes the configuration more intuitive while maintaining the same functionality.
- Removed Bun-related configurations and commands throughout the project.
- Updated all instances of `bunx` to `npx` in scripts, documentation, and configuration files.
- Deleted `bun.lock` and `bun.lockb` files, replacing them with `package-lock.json`.
- Adjusted CI/CD workflows to utilize npm commands for dependency installation and package management.
- Enhanced documentation to reflect the changes in package management and installation processes.

This transition aims to streamline the development workflow and improve compatibility across environments.
- project: @uniswap/ai-toolkit-nx-claude 0.5.10-next.3

- project: @ai-toolkit/utils 0.2.10-next.3

- project: @ai-toolkit/agents-agnostic 0.2.10-next.3

- project: @ai-toolkit/commands-agnostic 0.1.14-next.3

- project: @ai-toolkit/commands-typescript 0.1.11-next.3
#79)

### Summary of Changes
- Introduced a new command `daily-standup` that checks assigned Linear tasks and generates a team update.
- Documented the workflow process, execution steps, usage examples, and output format in `daily-standup.md`.
- Updated `index.ts` to include the new command with a brief description.

### Why This Change?
This addition enhances team communication by providing a structured update on ongoing tasks and recent GitHub activity, facilitating better collaboration during daily standups.
- project: @uniswap/ai-toolkit-nx-claude 0.5.10-next.4

- project: @ai-toolkit/utils 0.2.10-next.4

- project: @ai-toolkit/agents-agnostic 0.2.10-next.4

- project: @ai-toolkit/commands-agnostic 0.1.14-next.4

- project: @ai-toolkit/commands-typescript 0.1.11-next.4
- Regenerated lockfile using Node.js v22.21.0 (npm 10.9.4) to match CI environment
- Fixes dependency resolution and hoisting differences
- Ensures CI package-lock.json validation check passes
@wkoutre
wkoutre requested a review from a team as a code owner October 29, 2025 00:06
@vercel

vercel Bot commented Oct 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ai-toolkit-slack-oauth-backend Error Error Oct 29, 2025 0:07am

@graphite-app
graphite-app Bot requested a review from Melvillian October 29, 2025 00:07
@wkoutre wkoutre closed this Oct 29, 2025

- name: Setup Node.js
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep identified an issue in your code:
First step in each job must use bullfrogsec/bullfrog, unless the job is on macOS.

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by gh-actions-first-step-must-be-bullfrogsec.

You can view more details about this finding in the Semgrep AppSec Platform.

@@ -29,8 +23,8 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semgrep identified an issue in your code:
First step in each job must use bullfrogsec/bullfrog, unless the job is on macOS.

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by gh-actions-first-step-must-be-bullfrogsec.

You can view more details about this finding in the Semgrep AppSec Platform.

@semgrep-code-uniswap

Copy link
Copy Markdown

Semgrep found 1 gh-actions-first-step-must-be-bullfrogsec finding:

  • .github/workflows/pr-checks.yml

First step in each job must use bullfrogsec/bullfrog, unless the job is on macOS.

@wkoutre
wkoutre deleted the dgilman/package-fixes branch November 6, 2025 23:15
wkoutre added a commit that referenced this pull request Dec 2, 2025
<!-- claude-pr-description-start -->
## Summary

Enhances the `_generate-pr-metadata.yml` workflow to preserve user-added content in PR descriptions during AI regeneration. The workflow now wraps generated content with HTML comment markers, allowing users to add custom notes, disclaimers, or additional context that survives subsequent metadata updates.

## Changes

- **Content preservation markers**: Added `<!-- claude-pr-description-start -->` and `<!-- claude-pr-description-end -->` markers to wrap AI-generated PR descriptions
- **User content extraction**: Implemented logic to detect existing markers and extract content before/after them during regeneration
- **Smart description assembly**: Updated PR body construction to preserve user's prefix content (before start marker) and suffix content (after end marker) while replacing only the marked AI-generated section
- **Documentation**: Added comprehensive usage examples and feature explanation to `.github/workflows/CLAUDE.md`
- **Package versions**: Bumped package versions in `package-lock.json` from `-next.1` to `-next.2`

## Technical Details

The workflow now:
1. Fetches the current PR body using `gh pr view`
2. Uses `awk` to extract content before and after the markers
3. Assembles the final description by combining: preserved prefix + marked generated content + preserved suffix
4. Only replaces content between markers on subsequent regenerations

This enables workflows like:
```markdown
> **Note:** This PR requires manual QA testing before merge.

<!-- claude-pr-description-start -->
## Summary
... AI-generated content ...
<!-- claude-pr-description-end -->

---
**Related Issues:** #123, #456
```

Where both the note at the top and related issues at the bottom are preserved across regenerations.

## Benefits

- **Flexibility**: Users can add context-specific notes without losing them during AI regeneration
- **Collaboration**: Enables manual annotations alongside automated descriptions
- **Selective updates**: Only the AI-generated content is replaced, preserving intentional user additions
<!-- claude-pr-description-end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants