Skip to content

fix(development-pr-workflow): backtest-change also triggers for NEW monitors/gates #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanschmittle-uniswap wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(development-pr-workflow): backtest-change also triggers for NEW monitors/gates #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugins/development-pr-workflow/commands/backtest-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
description: Before opening a PR for a data-driven change (monitor threshold, alert routing/renotify, metric query, sampling rate, perf tweak), validate it against LIVE historical data — replay old-vs-new and report whether it actually achieves its goal. Refuses to ship (or redirects) when the data disproves the premise.
description: Before opening a PR for a data-driven change (monitor threshold, alert routing/renotify, metric query, sampling rate, perf tweak) — or a NEW monitor, gate, or alert whose threshold must be derived from historical data — validate it against LIVE historical data: replay old-vs-new (or the proposed threshold against history, e.g. a joint rate-AND-floor replay for gate composites) and report whether it actually achieves its goal. Refuses to ship (or redirects) when the data disproves the premise.
argument-hint: [what you're about to change + the metric/signal it should move]
allowed-tools: Bash(*), Read(*), Grep(*), Glob(*), AskUserQuestion(*)
---
Expand Down
Loading