-
Notifications
You must be signed in to change notification settings - Fork 11
chore(deps): bump claude-code-action to v1.0.185, quote --allowedTools #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
6148481
fb70db5
b19fb05
6a54c3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -409,7 +409,7 @@ jobs: | |
|
|
||
| # Add allowed tools (camelCase format) | ||
| if [[ -n "$INPUT_ALLOWED_TOOLS" ]]; then | ||
| ARGS="$ARGS--allowedTools $INPUT_ALLOWED_TOOLS"$'\n' | ||
| ARGS="$ARGS--allowedTools \"$INPUT_ALLOWED_TOOLS\""$'\n' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| fi | ||
|
|
||
| # Add disallowed tools | ||
|
|
@@ -457,7 +457,7 @@ jobs: | |
| # Supports both API key and OAuth token authentication (validated in earlier step) | ||
| - name: Run Claude Code | ||
| id: claude | ||
| uses: anthropics/claude-code-action@787c5a0ce96a9a6cfb050ea0c8f4c05f2447c251 # v1.0.133 | ||
| uses: anthropics/claude-code-action@9db594c7a0e82298c121c18b7f08aa1579ce7341 # v1.0.185 | ||
| with: | ||
| # Authentication: provide either API key or OAuth token (validated in earlier step) | ||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep identified an issue in your code:
Reusable workflow (on: workflow_call) uses
bun run. Bun auto-loads bunfig.toml from CWD, and its preload array executes arbitrary code before the intended script. If the workflow checks out fork PR code, this enables RCE with access to the caller's secrets. Fix: set BUN_CONFIG_FILE=/dev/null in the job env.To resolve this comment:
✨ Commit fix suggestion
View step-by-step instructions
Add
BUN_CONFIG_FILE: /dev/nullto the reusable workflow jobenvthat contains the Claude step and any otherbun runusage.This disables Bun's automatic loading of
bunfig.tomlfrom the checked-out working directory, so preload code in fork-controlled files does not execute.Place the setting at the job level so every step in that job inherits it, for example by updating the job to include
env: { BUN_CONFIG_FILE: /dev/null }or:env:BUN_CONFIG_FILE: /dev/nullKeep the existing
claude_argsonly if the workflow still needs Bun-based commands.Alternatively, if no Bun command is actually required in this reusable workflow, remove
Bash(bun run:*)from--allowedToolsto reduce exposure further.💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasonsAlternatively, triage in Semgrep AppSec Platform to ignore the finding created by bun-run-in-reusable-workflow.
You can view more details about this finding in the Semgrep AppSec Platform.