generated from Uniswap/foundry-template
-
Notifications
You must be signed in to change notification settings - Fork 0
E2E test suite #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ericneil-sanc
wants to merge
5
commits into
dev
Choose a base branch
from
e2e-rebased
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
E2E test suite #232
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // hardhat.config.ts | ||
| import "@nomicfoundation/hardhat-foundry"; | ||
| import "@nomicfoundation/hardhat-ethers"; | ||
| import "@typechain/hardhat"; | ||
|
|
||
| import type { HardhatUserConfig } from "hardhat/config"; | ||
| import { subtask } from "hardhat/config"; | ||
| import { TASK_COMPILE_SOLIDITY_GET_SOURCE_PATHS } from "hardhat/builtin-tasks/task-names"; | ||
| import path from "node:path"; | ||
| import * as glob from "glob"; | ||
|
|
||
| subtask(TASK_COMPILE_SOLIDITY_GET_SOURCE_PATHS, async (_, { config }) => { | ||
| const root = config.paths.root; | ||
| const contractSources = glob.sync(path.join(root, "src/**/*.sol")); | ||
| const testUtilsSources = glob.sync(path.join(root, "test/utils/**/*.sol")); | ||
| return [...contractSources, ...testUtilsSources].map((p) => path.normalize(p)); | ||
| }); | ||
|
|
||
| const config: HardhatUserConfig = { | ||
| solidity: { | ||
| version: "0.8.26", | ||
| settings: { | ||
| optimizer: { enabled: true, runs: 200 }, | ||
| viaIR: true, // Required for complex contracts | ||
ericneil-sanc marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }, | ||
| }, | ||
| networks: { | ||
| hardhat: { | ||
| blockGasLimit: 40_000_000, | ||
| accounts: { | ||
| count: 20, | ||
| initialIndex: 0, | ||
| mnemonic: "test test test test test test test test test test test junk", | ||
| path: "m/44'/60'/0'/0", | ||
ericneil-sanc marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| accountsBalance: "10000000000000000000000", // 10k ETH | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this also seems like the default
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AccountsBalance isnt but I will remove the rest |
||
| }, | ||
| }, | ||
| }, | ||
| paths: { | ||
| sources: "./src", | ||
| tests: "./test/e2e/tests", | ||
| cache: "./test/e2e/cache", | ||
| artifacts: "./test/e2e/artifacts", | ||
| }, | ||
| mocha: { | ||
| timeout: 300000, // 5 minutes for complex e2e tests | ||
| }, | ||
| typechain: { | ||
| outDir: "typechain-types", | ||
| target: "ethers-v6", | ||
| alwaysGenerateOverloads: false, | ||
| externalArtifacts: [ | ||
| "out/Auction.sol/Auction.json", | ||
| "out/AuctionFactory.sol/AuctionFactory.json", | ||
| "out/WorkingCustomMockToken.sol/WorkingCustomMockToken.json", | ||
| ], // Specific Foundry artifacts | ||
| dontOverrideCompile: false, // Let it compile if needed | ||
| }, | ||
| }; | ||
|
|
||
| export default config; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what this is for, can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sure that files in test/utils get compiled as well, instead of just src. which we need for the WorkingCustomMockToken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, could we just hardcode its abi or something? to reduce complexity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need its bytecode or artifact. Since we need to deploy it we need more than the ABI. But I can copy a copy of its artifact to test/e2e (in an artifact folder) and commit it if you think we should do that
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I would need to investigate if using a copy of its artifact would be fine, since the contract is used in typechain bindings, I may not be able to get to figure out if we could use a copy of its artifact until I get back