Conversation
marktoda
commented
Jul 11, 2025
marktoda
commented
- implement basic version of AssetSink and tests
- Consideration: should we have a batch release function? I opted for no since the releaser can just call it multiple times if needed
- Consideration: should we have a separate releaseERC20 and releaseNative? I opted to just use currencylibrary for simplicity
- configuration: currently just using an immutable releaser address but in the future we will likely depend on an immutable config contract instead
- implement basic version of AssetSink and tests - Consideration: should we have a batch release function? I opted for no since the releaser can just call it multiple times if needed - Consideration: should we have a separate releaseERC20 and releaseNative? I opted to just use currencylibrary for simplicity - configuration: currently just using an immutable releaser address but in the future we will likely depend on an immutable config contract instead
|
note I deleted bunch of existing stuff that is unlikely to be used directly, including the old asset sink which had burn builtin |
| // SPDX-License-Identifier: AGPL-3.0-only | ||
| pragma solidity ^0.8.29; | ||
|
|
||
| import {Currency, CurrencyLibrary} from "v4-core/types/Currency.sol"; |
There was a problem hiding this comment.
super nit - it does seem strange to have v4 be a dependency, probably can at some point port these to a generic repo?
There was a problem hiding this comment.
yeah was wondering about that too, but assume we will need other v4 stuff (ie IProtocolFeeController etc etc) so thought it was ok to have for now
| /// @param asset The asset to release | ||
| /// @param recipient The address to receive the assets | ||
| /// @dev Only callable by the releaser address | ||
| function release(Currency asset, address recipient) external onlyReleaser { |
There was a problem hiding this comment.
thoughts on adding a batch functionality? so the releaser could do multiple tokens in one call
There was a problem hiding this comment.
should most certainly have batch functionality if we want the efficiency of frequent calls & value accrual
but can go in another PR
There was a problem hiding this comment.
Yeah
Consideration: should we have a batch release function? I opted for no since the releaser can just call it multiple times if needed
definitely down to add later but figured for now simplicity and starting point its ok to go without
snreynolds
left a comment
snreynolds
left a comment
There was a problem hiding this comment.
basically no notes, looks great
3 participants
