fix: always sends two async calls when the tokenIn or tokenOut is either ETH or WETH #1255

jsy1218 · 2025-11-06T00:26:03Z

Currently, we see two problems with the async lambda call (async caching update):

when tokenIn/tokenOut is ETH, and in cache entries there are only WETH/* cached routes, then routing will not make a ETH async call, but only WETH async call
when tokenIn/tokenOut is WETH, regardless of what's in the cache entries, routing will only make WETH async call, no ETH async call.

Desired behavior is:

when tokenIn/tokenOut is ETH, we make two async calls, one for ETH/, the other for WETH/
when tokenIn/tokenOut is WETH, we also make two async calls, one for ETH/, the other for WETH/

In order to achieve this, we need to make sure, we always try to query the dynamo with both ETH/* and WETH/* cache entries.

jsy1218 · 2025-11-06T00:26:17Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2025-11-06T00:55:32Z

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (11/06/25)

4 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

cgkol · 2025-11-06T04:13:29Z

We also pass through those permit params just in case the tokenIn already has the permit2.

what dos this mean exactly? all tokens have permit2 right?

cgkol · 2025-11-06T04:31:03Z

lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts

      },
      queryStringParameters: {
-        tokenInAddress: getSymbolOrAddress(partitionKey.currencyIn, partitionKey.chainId),
+        tokenInAddress: currencyIn.isNative ? currencyIn.symbol : currencyIn.address,


i am still having a hard time wrapping my head around this;

is the issue that partitionKey.currencyIn might incorrectly not be classified as addressZero aka the native token, therefore, we won't update correctly?

i think this does the same thing as before;

when you have a native, you would pass down ADDRESS_ZERO which before would be updated with the symbol. Now, you are passing the symbol just by checking if its native or not, but that sa check you can do based on the currencyIn address (which should be 0)

this will be reverted

jsy1218 · 2025-11-07T21:51:57Z

lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts

+        tokenInAddress: currencyIn.isNative ? currencyIn.symbol : currencyIn.address,
        tokenInChainId: partitionKey.chainId.toString(),
-        tokenOutAddress: getSymbolOrAddress(partitionKey.currencyOut, partitionKey.chainId),
+        tokenOutAddress: currencyOut.isNative ? currencyOut.symbol : currencyOut.address,


this will be reverted

jsy1218 · 2025-11-07T21:52:06Z

lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts

+        slippageTolerance: swapOptions?.slippageTolerance?.toFixed(2),
+        simulateFromAddress: swapOptions?.simulate?.fromAddress,
+        recipient: swapOptions?.recipient,
+        deadline:
+          parseInt((swapOptions as SwapOptionsUniversalRouter).deadlineOrPreviousBlockhash?.toString() ?? '0') -
+          Math.floor(Date.now() / 1000),
+        permitSignature: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.signature,
+        permitNonce: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.details?.nonce,
+        permitExpiration: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.details?.expiration,
+        permitAmount: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.details?.amount,
+        permitToken: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.details?.token,
+        permitSpender: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.spender,
+        permitSigDeadline: (swapOptions as SwapOptionsUniversalRouter).inputTokenPermit?.sigDeadline,


we prob need to keep those

cgkol

So with the new changes, you guarantee that you'll pull cache results for both eth/weth everytime you call either, but are we guaranteed that it will update both?

cgkol · 2025-11-07T22:14:22Z

lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts

      }

-      const result = await this.ddbClient.query(queryParams).promise()
+      const additionalQueryParams = DynamoRouteCachingProvider.getAdditionalQueryParams(currencyIn, currencyOut, tradeType, chainId, includesV4Pool, this.routesTableName)


lets add some comments epxlaining why we do this

…he entry, we'd still send the async call

socket-security · 2025-11-10T17:03:39Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@uniswap/sdk-core@7.8.0 ⏵ 7.9.0			⁺¹	⁺³
	@uniswap/smart-order-router@4.22.30 ⏵ 4.22.31	^-6			^-3	^-30

View full report

cgkol

delete code from other places

xrsv · 2025-11-12T23:58:30Z

lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts

          alphaRouterConfig,
          swapOptions
        )
+      } else if (currencyIn.isNative || currencyOut.isNative) {


this will probably work

jsy1218 marked this pull request as ready for review November 6, 2025 00:45

graphite-app bot requested a review from cgkol November 6, 2025 00:54

graphite-app bot assigned jsy1218 Nov 6, 2025

graphite-app bot requested review from a team and xrsv November 6, 2025 00:54

cgkol reviewed Nov 6, 2025

View reviewed changes

jsy1218 commented Nov 7, 2025

View reviewed changes

jsy1218 changed the title ~~fix: pass in correct async lambda query string params for caching and deleting cached routes upon sim failures~~ fix: always sends two async calls when the tokenIn or tokenOut is either ETH or WETH Nov 7, 2025

cgkol reviewed Nov 7, 2025

View reviewed changes

fix: when currencyIn/currencyOut is native, even if we don't have cac…

68c55cf

…he entry, we'd still send the async call

jsy1218 force-pushed the siyujiang/route-777-debug-why-cached-routes-are-not-getting-updated branch from 6780fc5 to 68c55cf Compare November 9, 2025 21:56

fix: monad v4 fix in SOR

0c99521

cgkol approved these changes Nov 10, 2025

View reviewed changes

cgkol requested changes Nov 10, 2025

View reviewed changes

xrsv reviewed Nov 12, 2025

View reviewed changes

fix: always sends two async calls when the tokenIn or tokenOut is either ETH or WETH #1255

Are you sure you want to change the base?

fix: always sends two async calls when the tokenIn or tokenOut is either ETH or WETH #1255

Uh oh!

Conversation

jsy1218 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsy1218 commented Nov 6, 2025

Uh oh!

graphite-app bot commented Nov 6, 2025

Graphite Automations

Uh oh!

cgkol commented Nov 6, 2025

Uh oh!

cgkol Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

cgkol Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

jsy1218 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

jsy1218 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

jsy1218 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

cgkol left a comment

Choose a reason for hiding this comment

Uh oh!

cgkol Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Nov 10, 2025

Uh oh!

cgkol left a comment

Choose a reason for hiding this comment

Uh oh!

xrsv Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jsy1218 commented Nov 6, 2025 •

edited

Loading