feat(breaking): Smart wallet upgrade #354
Conversation
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (04/14/25)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
| } | ||
|
|
||
| /** Internal methods */ | ||
|
|
||
| protected static _encodeExecute(mode: ModeType, data: `0x${string}`): `0x${string}` { | ||
| protected static _encodeERC7821Execute(mode: ModeType, data: `0x${string}`): `0x${string}` { |
There was a problem hiding this comment.
imo we should be encoding calldata as a direct call to execute not through the 7821 wrapper!
There was a problem hiding this comment.
this is only supported for the legacy mode if desired, I marked it as deprecated do you think we should just remove it all together?
There was a problem hiding this comment.
I mean I can't see our internal code using this codepath but I think its fair to support in the sdk !
| const mode = this.getModeFromOptions(options) | ||
| if(mode != ModeType.BATCHED_CALL && mode != ModeType.BATCHED_CALL_CAN_REVERT) { | ||
| throw new Error(`Invalid mode: ${mode}`) | ||
| } |
There was a problem hiding this comment.
So yeah I think this entrypoint should just be the direct encoding, not 7821 encoding
There was a problem hiding this comment.
so it seems like you can just remove these lines/not support a mode being passed in
There was a problem hiding this comment.
Agree that default should be via BatchedCall. I think its fine to use executeOptions here since that's what we use in other functions
Changelog
Breaking Changes
encodeCallsmethod: This method has been completely removedencodeBatchedCallis now the main method for encoding call batchesencodeCalls(acceptscalls[]andoptions)MethodParametersobject type as beforeshouldRevertin BatchedCallPlanner is nowtrue, meaning batched calls will revert by default if any call failsAdded
BatchedCallPlannerclass to handle batched calls with revert controlencodeERC7821BatchedCallmethod for legacy support of the ERC-7821 specificationencodeBatchedCallmethodMigration Guide
This update simplifies the API while maintaining backward compatibility through parameter structure. The main behavioral difference is that batched calls will now revert by default when any contained call fails, improving safety by preventing partial execution of transaction batches.
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.