-
Notifications
You must be signed in to change notification settings - Fork 127
feat(breaking): Smart wallet upgrade #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (04/14/25)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
snreynolds
reviewed
Apr 15, 2025
snreynolds
reviewed
Apr 15, 2025
snreynolds
reviewed
Apr 15, 2025
snreynolds
reviewed
Apr 15, 2025
Ayoakala
approved these changes
Apr 15, 2025
snreynolds
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Breaking Changes
encodeCalls
method: This method has been completely removedencodeBatchedCall
is now the main method for encoding call batchesencodeCalls
(acceptscalls[]
andoptions
)MethodParameters
object type as beforeshouldRevert
in BatchedCallPlanner is nowtrue
, meaning batched calls will revert by default if any call failsAdded
BatchedCallPlanner
class to handle batched calls with revert controlencodeERC7821BatchedCall
method for legacy support of the ERC-7821 specificationencodeBatchedCall
methodMigration Guide
This update simplifies the API while maintaining backward compatibility through parameter structure. The main behavioral difference is that batched calls will now revert by default when any contained call fails, improving safety by preventing partial execution of transaction batches.
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...
), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.