Skip to content

Conversation

@jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Dec 23, 2025

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]


✨ Claude-Generated Content

Description

Bumps @uniswap/v4-sdk dependency in router-sdk from ^1.24.0 to ^1.25.0 to align with the Universal Router 2.1 revert changes.

Changes

  • Updated @uniswap/v4-sdk version in sdks/router-sdk/package.json from ^1.24.0 to ^1.25.0
  • Updated yarn.lock to reflect the new dependency version

How Has This Been Tested?

Will be tested in routing pipeline.

Are there any breaking changes?

No

@jsy1218 jsy1218 marked this pull request as ready for review December 23, 2025 22:39
@jsy1218 jsy1218 requested a review from a team as a code owner December 23, 2025 22:39
Copy link
Member Author

jsy1218 commented Dec 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

🤖 Claude Code Review

Review complete

Summary

This PR bumps the @uniswap/v4-sdk dependency from ^1.24.0 to ^1.25.0 in the router-sdk package. The commit message indicates this is related to a UR 2.1 revert.

Review

Straightforward dependency version bump. No code changes, just updating the v4-sdk version constraint and the corresponding yarn.lock entries.

No issues found.


💡 Want a fresh review? Add a comment containing @request-claude-review to trigger a new review at any time.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review verdict: APPROVE

👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.

This formal review submission is for the verdict only.

@graphite-app graphite-app bot requested a review from a team December 23, 2025 22:46
@graphite-app
Copy link

graphite-app bot commented Dec 23, 2025

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/23/25)

2 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218 jsy1218 merged commit b436065 into main Dec 23, 2025
11 of 12 checks passed
@jsy1218 jsy1218 deleted the siyujiang/bump-router-sdk branch December 23, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants