Skip to content

Conversation

@dianakocsis
Copy link
Contributor

@dianakocsis dianakocsis commented Jan 7, 2026

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]


✨ Claude-Generated Content

Description

Adds a test case for exact output split routes that end in ETH-WETH pools. This test validates the encoding of split routes where both V3 and V4 trades output ETH, with the V4 route going through an ETH-WETH pool.

Changes

  • Added test encodes an exact output ending in ETH-WETH in sdks/universal-router-sdk/test/uniswapTrades.test.ts
    • Tests V3 route: USDC -> WETH -> ETH (via unwrap)
    • Tests V4 route: USDC -> ETH -> ETH-WETH pool -> ETH
    • Registers fixture _UNISWAP_SPLIT_TWO_ROUTES_ENDING_IN_ETH_WETH
  • Added temporary SDK tarballs in sdks/tmp/ for local testing (router-sdk.tgz, v4-sdk.tgz)

How Has This Been Tested?

Unit test added to verify the encoding of exact output split routes ending in ETH-WETH pools.

Are there any breaking changes?

No

Notes

This PR includes temporary tgz files in sdks/tmp/ that appear to be debugging artifacts and may need to be removed before merging.

@github-actions github-actions bot changed the title pr to debug testing failures test(universal-router-sdk): add exact output ETH-WETH split route test Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants