test(universal-router-sdk): add exact output ETH-WETH split route test #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):will trigger a patch versionchore(<type>):will not trigger any release and should be used for internal repo changes<type>(public):will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):will trigger a minor versionfeat(breaking):will trigger a major version for a breaking changeDescription
[Summary of the change, motivation, and context]
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]
✨ Claude-Generated Content
Description
Adds a test case for exact output split routes that end in ETH-WETH pools. This test validates the encoding of split routes where both V3 and V4 trades output ETH, with the V4 route going through an ETH-WETH pool.
Changes
encodes an exact output ending in ETH-WETHinsdks/universal-router-sdk/test/uniswapTrades.test.ts_UNISWAP_SPLIT_TWO_ROUTES_ENDING_IN_ETH_WETHsdks/tmp/for local testing (router-sdk.tgz, v4-sdk.tgz)How Has This Been Tested?
Unit test added to verify the encoding of exact output split routes ending in ETH-WETH pools.
Are there any breaking changes?
No
Notes
This PR includes temporary tgz files in
sdks/tmp/that appear to be debugging artifacts and may need to be removed before merging.