feat(sdk-core): add CurrencyAmount comparator overrides with currency… - #576
Open
shubhamessier wants to merge 1 commit into
Open
feat(sdk-core): add CurrencyAmount comparator overrides with currency…#576shubhamessier wants to merge 1 commit into
shubhamessier wants to merge 1 commit into
Conversation
Author
|
Hey @mikeki, would appreciate your review here. cc: @ciamac @ccashwell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CurrencyAmount Comparison Overrides
Adds
lessThan,equalTo, andgreaterThanoverrides onCurrencyAmount. Comparing amounts of different currencies now throws a'CURRENCY'error, matching the existing behavior ofaddandsubtract.The operand type is narrowed to
CurrencyAmount<T> | 0, where0is a sentinel for zero comparisons. This rejects bareBigintIshvalues at the type level.Internal callers in
v2-sdkandrouter-sdkare updated to use0in place ofJSBI.BigInt(0).Validation
All existing tests pass (22 + 103 + 338 + 240 + 360). Type checking and linting are clean.
Changesets
@uniswap/sdk-core: minor@uniswap/v2-sdk: patch@uniswap/router-sdk: patch