fix(sdks): include source content in sourcemaps - #652
Open
xxxxxmax wants to merge 1 commit into
Open
Conversation
xxxxxmax
marked this pull request as ready for review
July 17, 2026 19:38
xxxxxmax
requested review from
aayala-uniswap,
charlesma4,
dylanschmittle-uniswap,
eugene-uniswap,
paranoiacblack and
trianglesphere
July 17, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Scope
This is a packaging/source-map fix across SDK packages that publish compiled TypeScript output.
Description
The SDK packages currently emit JavaScript sourcemaps, but published npm packages only include
dist. The generated.js.mapfiles reference original TypeScript paths such as../../../src/index.tswithout embeddingsourcesContent, so downstream tooling that resolves sourcemaps from the published package can warn that the source files are missing.This sets
inlineSources: truealongsidesourceMap: truefor the SDKtsconfig.base.jsonfiles so generated sourcemaps include the original TypeScript source content. Runtime JavaScript and type declaration output are unchanged; only sourcemap contents change.How Has This Been Tested?
bun install --frozen-lockfilebun run g:buildbun run g:lintbun run g:typechecksdks/sdk-core/dist/esm/src/index.js.mapsdks/router-sdk/dist/esm/src/index.js.mapsdks/universal-router-sdk/dist/esm/src/index.js.mapsdks/v3-sdk/dist/esm/src/entities/pool.js.mapEach inspected map now contains
sourcesContententries.Are there any breaking changes?
No. This only changes emitted sourcemap metadata and adds source content to the generated
.js.mapfiles.(Optional) Feedback Focus
Please confirm that inlining source content in sourcemaps is preferred over publishing
srcfiles or disabling sourcemap emission.