Skip to content

fix(sdk-core): split Quoter and QuoterV2, correct deployment addresses - #668

Open
TanmayDagur wants to merge 2 commits into
Uniswap:mainfrom
TanmayDagur:fix/sdk-core-celo-alfajores-optimism-migrator-addresses
Open

fix(sdk-core): split Quoter and QuoterV2, correct deployment addresses#668
TanmayDagur wants to merge 2 commits into
Uniswap:mainfrom
TanmayDagur:fix/sdk-core-celo-alfajores-optimism-migrator-addresses

Conversation

@TanmayDagur

Copy link
Copy Markdown

Resolves #659

Summary

This pull request addresses the architectural conflation of Quoter (V1) and QuoterV2 within the sdk-core address inventory, and fixes several missing or incorrect TickLens and SwapRouter02 records. Treating V2 addresses as V1 (or vice versa) can cause ABI decoding failures due to their different return types.

Changes

  • Separated Quoter and QuoterV2: Updated the ChainAddresses interface to make quoterAddress optional, and added an optional quoterV2Address.
  • Removed Default V1 Quoter: Removed the hardcoded V1 quoterAddress from DEFAULT_ADDRESSES since many chains (e.g. Sepolia, Zora) do not have a V1 deployment.
  • New Export: Added export const QUOTER_V2_ADDRESSES to surface true V2 addresses.
  • Ground-Truth Addresses: Fetched the official developers.uniswap.org/deployments.json feed and programmatically mapped the correct quoterAddress, quoterV2Address, tickLensAddress, and swapRouter02Address deployments for all active networks.
  • Fixed Fallbacks: Updated SWAP_ROUTER_02_ADDRESSES and QUOTER_ADDRESSES to correctly return undefined for chains where they are not deployed, rather than defaulting to the Ethereum mainnet router/quoter.

Verification

  • bun test passes successfully for all 387 test cases.
  • bun run typecheck passes with no strict null check errors.
  • bun run build generates the required distribution and .d.ts files without issues.
  • bun run lint shows no warnings or errors.

@TanmayDagur
TanmayDagur requested a review from a team as a code owner August 1, 2026 11:59
@datadog-official

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

Check PR Title | conventional-commit   View in Datadog   GitHub Actions

See error No release type found in pull request title. Prefix required to indicate release type for 'Fix/sdk core celo alfajores optimism migrator addresses'.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e7d6b3e | Docs | Datadog PR Page | Give us feedback!

@TanmayDagur TanmayDagur changed the title Fix/sdk core celo alfajores optimism migrator addresses fix(sdk-core): split Quoter and QuoterV2, correct deployment addresses Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sdk-core: correct deployment addresses and split Quoter/QuoterV2

1 participant