Skip to content

[Fix] Update Arbitrum Sepolia WETH9 & Wrapped Native address #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Nikita-Polyakov
Copy link
Contributor

I found a mismatch of WETH address for the Arbitrum Sepolia network between this library and sdk-core. The correct address is taken from the sdk-core library.

To eliminate such mismatches, I used the WETH9 constant from the sdk-core library.

@Nikita-Polyakov Nikita-Polyakov requested a review from a team as a code owner March 20, 2025 13:15
@jsy1218
Copy link
Member

jsy1218 commented Mar 28, 2025

thanks for catching

@Nikita-Polyakov
Copy link
Contributor Author

@jsy1218 I've added non-null assertions to fix build checks, and bumped version in package.json. Could you check these updates please?

@jsy1218
Copy link
Member

jsy1218 commented Apr 1, 2025

@jsy1218 I've added non-null assertions to fix build checks, and bumped version in package.json. Could you check these updates please?

on it

@jsy1218
Copy link
Member

jsy1218 commented Apr 1, 2025

@Nikita-Polyakov I'm not sure why 403 to https://registry.npmjs.org/camelcase-keys/-/camelcase-keys-6.2.2.tgz, presumably it might be due to forked repo, instead of Uniswap repo itself.

Can you try merging from Nikita-Polyakov:main to siyujiang/fix-arb-sepolia-weth9-wrapped-native-address, then I will create a PR to merge into Uniswap:main

@Nikita-Polyakov
Copy link
Contributor Author

Nikita-Polyakov commented Apr 2, 2025

@Nikita-Polyakov I'm not sure why 403 to https://registry.npmjs.org/camelcase-keys/-/camelcase-keys-6.2.2.tgz, presumably it might be due to forked repo, instead of Uniswap repo itself.

Can you try merging from Nikita-Polyakov:main to siyujiang/fix-arb-sepolia-weth9-wrapped-native-address, then I will create a PR to merge into Uniswap:main

I've tried to merge changes directly, but looks like i haven't enought rights for this, or i did it not corretly. So i created a PR to your branch:
#851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants