V1 #65

0age · 2025-04-08T18:18:20Z

This PR is meant to serve as a forum for review and comments for V1 development. Work is still underway on implementing the final V1 feature set.

removing slot allocation

Fixed IdLib

Fixed permit2 multi chain depositAndRegister

Fuzz toCompactId tests

bump version to 1 and drop counterfactual address

…sor (2,344 free runtime bytes @ max)

…1146 bytes

Drop unused v1 claim endpoints

Optimize verifyClaim & shortest reset period derivation; get under size limit @ max runs

Use Locktag for Permit2

Co-authored-by: Alexander <[email protected]>

make progress on stack depth issues when running coverage

codecov-commenter · 2025-04-16T19:43:19Z

Codecov Report

Attention: Patch coverage is 75.79972% with 174 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@64a19d3). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/TheCompact.sol	32.50%	54 Missing ⚠️
src/lib/EmissaryLib.sol	75.00%	14 Missing and 3 partials ⚠️
src/lib/HashLib.sol	62.79%	16 Missing ⚠️
src/lib/ValidityLib.sol	73.21%	15 Missing ⚠️
src/lib/TransferLib.sol	70.96%	7 Missing and 2 partials ⚠️
src/lib/AllocatorLib.sol	78.78%	7 Missing ⚠️
src/lib/DepositViaPermit2Lib.sol	64.70%	6 Missing ⚠️
src/lib/WithdrawalLogic.sol	0.00%	6 Missing ⚠️
test/unit/Emissary/MockEmissaryLogic.sol	57.14%	6 Missing ⚠️
src/lib/RegistrationLogic.sol	58.33%	5 Missing ⚠️
... and 11 more

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage        ?   72.93%           
=======================================
  Files           ?       40           
  Lines           ?     1633           
  Branches        ?       97           
=======================================
  Hits            ?     1191           
  Misses          ?      432           
  Partials        ?       10

Files with missing lines	Coverage Δ
src/lib/AllocatorLogic.sol	`84.61% <100.00%> (ø)`
src/lib/ClaimHashFunctionCastLib.sol	`100.00% <100.00%> (ø)`
src/lib/ClaimHashLib.sol	`100.00% <100.00%> (ø)`
src/lib/ClaimProcessor.sol	`100.00% <100.00%> (ø)`
src/lib/ClaimProcessorFunctionCastLib.sol	`100.00% <100.00%> (ø)`
src/lib/ClaimProcessorLib.sol	`100.00% <100.00%> (ø)`
src/lib/ClaimProcessorLogic.sol	`100.00% <100.00%> (ø)`
src/lib/DepositLogic.sol	`50.00% <100.00%> (ø)`
src/lib/DomainLib.sol	`100.00% <100.00%> (ø)`
src/lib/EfficiencyLib.sol	`94.11% <100.00%> (ø)`
... and 26 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a19d3...319db04. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

trigger coverage

remove some unused functionality

zeroknots and others added 30 commits February 14, 2025 14:48

fix(exogenous hashing): bug when hashing more that 1 other segment

59c6a71

removing slot allocation

fixed compact flag calculation

b1ab669

fixed depositAndRegister via Permit2 with a multi chain compact

d321a6a

Merge pull request #43 from Uniswap/idlib-fix

90df32b

Fixed IdLib

decreased optimizer runs

e9ae7fa

Merge branch 'main' into permit2-multi-chain

285345c

adapted target address

44621cd

Merge pull request #44 from Uniswap/permit2-multi-chain

99c3321

Fixed permit2 multi chain depositAndRegister

Fuzz toCompactId

1e39b27

increase fuzz runs

f90dc61

fix config syntax

3b5e494

Merge pull request #45 from Uniswap/more-testing-pr-43

9f76dc9

Fuzz toCompactId tests

bump version to 1 and drop counterfactual address

c5c8fbd

Merge pull request #47 from Uniswap/v1-version-bump

1cf5284

bump version to 1 and drop counterfactual address

delete qualification (will be handled by allocators via callback)

96e3eb0

fmt

2f80994

snapshots

8c6dd59

remove no-witness claims and non-split claims

f7b0ecd

fmt

92188b0

simplify struct names

c209f17

update description with current state

dbd2724

pump up optimization runs (7,484 free runtime bytes @ 100, 2,281 @ max)

f5e2987

Remove unused functions and asStubborn from ClaimHash and ClaimProces…

b49cf93

…sor (2,344 free runtime bytes @ max)

Allow registration for someone else

e9c6fbc

Minor contract size optimisation

0e4e96e

Use provided reset period instead of expiry as reset period, excess: …

af8b67c

…1146 bytes

Fix forge fmt error

8c90eb5

feat: depreciate unused non-witness interfaces

2e242a0

rebase on new interfaces (1,759 @ max)

b43c4e6

Merge pull request #48 from Uniswap/drop-unused-v1-claim-endpoints

f94d789

Drop unused v1 claim endpoints

reednaa and others added 24 commits April 10, 2025 14:49

Permit2 using lockTag

d210bc9

forge fmt (1,914 @ max)

d2ad419

begin a nonzero loop at second element; drop bool internal fn returns

34b0872

Merge pull request #72 from Uniswap/optimize-verify-claim

5247d46

Optimize verifyClaim & shortest reset period derivation; get under size limit @ max runs

Merge branch 'v1' into locktag-permit2

499abec

update snapshots

a07eb31

Replace function selector with function signature in tests

44854e8

Update uint and comment from review

0c6f218

Merge pull request #73 from Uniswap/locktag-permit2

2ec42a3

Use Locktag for Permit2

Update src/lib/ValidityLib.sol

a997e8d

Co-authored-by: Alexander <[email protected]>

make progress on stack depth issues when running coverage

a893e2c

snapshot run

b6b49b6

chore: improve permit2-based deposit interface

b3cf2e2

chore: fix formatting

6d3572e

fix compiler warning

dc60a68

chore: test suite cleanup and deduplication

1ee8953

snapshot

d293258

get about halfway through stack refactor of tests

69d599d

more progress on a few particularly gnarly ones

389b101

get it all working

d8c2ac2

add coverage step to CI

86645c7

push to codecov

92f404b

use v5

9742b2b

Merge pull request #75 from Uniswap/coverage-stack-juggling

12be945

make progress on stack depth issues when running coverage

0age added 5 commits April 16, 2025 15:43

trigger coverage

3928acf

Merge pull request #76 from Uniswap/trigger-coverage

448d626

trigger coverage

remove some unused functionality

eb81865

fmt

d02fb56

Merge pull request #77 from Uniswap/unused-stuff

319db04

remove some unused functionality

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V1 #65

V1 #65

0age commented Apr 8, 2025 •

edited

Loading

codecov-commenter commented Apr 16, 2025 •

edited

Loading

V1 #65

Are you sure you want to change the base?

V1 #65

Conversation

0age commented Apr 8, 2025 • edited Loading

codecov-commenter commented Apr 16, 2025 • edited Loading

Codecov Report

0age commented Apr 8, 2025 •

edited

Loading

codecov-commenter commented Apr 16, 2025 •

edited

Loading