Skip to content

chore(ci): bump review-cli to 1.10.6 - #145

Open
claude[bot] wants to merge 1 commit into
mainfrom
claude/bump-review-cli-1.10.6
Open

chore(ci): bump review-cli to 1.10.6#145
claude[bot] wants to merge 1 commit into
mainfrom
claude/bump-review-cli-1.10.6

Conversation

@claude

@claude claude Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Requested by Erin Hales · Slack thread

Bumps the pinned @uniswap/review-cli version from 1.10.1 to 1.10.6.

What changed

Two lines, both under .github/workflows/:

  • claude-code-review.yml:109 — the REVIEW_CLI_VERSION env: fallback, consumed by the bun add "@uniswap/review-cli@${REVIEW_CLI_VERSION}" step. That var is declared once at workflow level and read by both install blocks (the triage job at line 220 and the review job at line 426), so the single edit covers both and they cannot drift apart.
  • CLAUDE.md:329 — the Repository Variables table, which states the default in prose (defaults to 1.10.1). Updated alongside the workflow; leaving it would have made the docs contradict the workflow.

Nothing else changed. There is deliberately no package.json entry and no lockfile regeneration: review-cli is installed ad-hoc into $RUNNER_TEMP at job time and has no manifest or lockfile reference in this repo. A repo-wide grep confirms no other review-cli version literal remains.

This is only the fallback — the repo variable still needs bumping

vars.REVIEW_CLI_VERSION is the authoritative pin; 1.10.6 is just the || fallback behind it. A PR cannot set a repo variable, so if vars.REVIEW_CLI_VERSION is set on this repo it will keep winning and merging this alone changes nothing at runtime. It needs bumping separately in repo settings → Variables for this to take effect.

Per .github/workflows/CLAUDE.md, only NODE_VERSION and NPM_VERSION are actually set on this repo today, so as documented the fallback is currently load-bearing and this change should take effect on merge. Worth a quick confirm against live repo settings, since the doc could itself be stale.

Validation

Check Result
Workflow YAML parses Pass — env.REVIEW_CLI_VERSION resolves to the expected string
bun run lint:actions (actionlint v1.7.7) Pass, 0 findings across all 10 workflows
markdownlint-cli2 on the edited doc Pass, 0 errors
bunx nx format:check --uncommitted Pass
lefthook pre-commit (actionlint, format, lint) All 3 pass
Grep for stale 1.10.1 / review-cli Clean

The only remaining 1.10.1 hits in the tree are the uniswap-trading plugin's own package version (a coincidental collision, correctly untouched) and unrelated transitive deps in bun.lock. No version: key was touched — the diff is exactly two lines.

bun run docs:lint (vale) reports 296 pre-existing spelling errors across 40 files, all in docs/. That is unrelated to this PR: vale is scoped to docs/**/*.md by .vale.ini, and git diff origin/main -- docs/ is empty, so its output is byte-identical before and after this change. It also means vale does not cover the .github/workflows/CLAUDE.md edit — markdownlint-cli2 does, and it passes.

Note for reviewers

The comment directly above the edited line still reads "Fallback matches what Uniswap/universe runs today." I left it alone rather than widen the diff, but it is only accurate if universe is on 1.10.6 too — worth a glance if these bumps are landing at different times across repos.


Generated by Claude Code

Move the `REVIEW_CLI_VERSION` fallback in claude-code-review.yml from 1.10.1
to 1.10.6, and update the repository-variables table in
.github/workflows/CLAUDE.md so the documented default matches.

The literal is only the fallback behind the `vars.REVIEW_CLI_VERSION` repo
variable, which is not set on this repo today, so the fallback is
load-bearing.
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
uniswap-ai-docs Ready Ready Preview Aug 21, 2026 4:57pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Claude PR Metadata Generation

Status: ❌ Error
Job: View workflow run


⚠️ Generation Failed

The automated PR title and description generation encountered an error.

Next Steps:

  1. Check the workflow logs for details
  2. Verify the GitHub Actions configuration
  3. Ensure the Anthropic API key is valid

You can manually set the PR title and description, or re-trigger by pushing a new commit.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

● Reviewed · against 09944f9 · 2026-08-21 17:05 UTC · view run ↗

Note

Approved.

Bumps the pinned review-cli version from 1.10.1 to 1.10.6 in the CI workflow fallback and matching documentation.

Assessment

Two-line change: the REVIEW_CLI_VERSION env var in claude-code-review.yml and the corresponding default in the workflow documentation table. The variable is read by both install blocks (triage and review jobs), so they stay in sync.

This is a CI-only dev tool—installed ad-hoc at job runtime, never in package.json, no lockfile entry. The security posture (isolated install, pre-checkout execution, credential cleanup) remains intact. If the new version were broken, this PR's own review job would have failed; it passed.

The only stale reference is the comment at line 108 ("Fallback matches what Uniswap/universe runs today"), which the PR description explicitly left alone to avoid widening the diff. Worth confirming universe is also on 1.10.6 if these bumps land at different times.

Tip

Teach the reviewer. React 👍 on findings that helped, 👎 on false positives. Reply to push back or add context — we aggregate this weekly to tune the bot.

Comment @request-claude-review to re-run.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Approved — see full review in the sticky comment ↑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant