zora addresses #439
Merged
zora addresses #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Jan 22, 2025
| pairInitCodeHash: 0x96e8ac4277198ff8b6f785478aa9a39f403cb768dd02cbee326c3e7da348845f, | ||
| poolInitCodeHash: 0xe34f199b19b2b4f47f68442619d555527d244f78a3297ea89325f843f87b8b54, | ||
| v4PoolManager: address(0), | ||
| v3NFTPositionManager: 0x7145F8aeef1f6510E92164038E1B6F8cB2c42Cbb, |
Collaborator
There was a problem hiding this comment.
this is the v3 factory, it should be 0xbC91e8DfA3fF18De43853372A3d7dfe585137D78
Member
There was a problem hiding this comment.
ya should be 0xbC91e8DfA3fF18De43853372A3d7dfe585137D78
hensha256
reviewed
Jan 22, 2025
| import {DeployUniversalRouter} from '../DeployUniversalRouter.s.sol'; | ||
| import {RouterParameters} from 'contracts/types/RouterParameters.sol'; | ||
|
|
||
| contract DeployWorldchain is DeployUniversalRouter { |
Collaborator
There was a problem hiding this comment.
Suggested change
| contract DeployWorldchain is DeployUniversalRouter { | |
| contract DeployZora is DeployUniversalRouter { |
hensha256
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.