fix: Tempo deploy script compilation and stale foundry.lock - #492
Open
gretzke wants to merge 1 commit into
Open
Conversation
… sync foundry.lock DeployTempo.s.sol was added in #478 against the pre-#476 RouterParameters struct, so a clean checkout of main fails to compile with a struct constructor argument count error. I added the missing permissionsAdapterFactory field as address(0), matching the other deployers that don't have a factory yet. foundry.lock was also left stale by #476: it still pinned forge-std at v1.5.5 and v4-periphery at a pre-Permissioned-Pools commit while the git submodule pointers were bumped. I synced the two rev entries to the committed submodule revisions, which removes the revision mismatch warnings on every forge build.
alanhwu
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean checkout of main currently fails
forge build. DeployTempo.s.sol was added in #478 but written against the RouterParameters struct from before #476, which added the permissionsAdapterFactory field, so the struct constructor in the Tempo deployer is one argument short. I added the missing field as address(0), the same way the fix that's sitting on feat/v4-swap-within-unlock-hardened does it.While debugging this I also noticed foundry.lock was left stale by #476: it still pins forge-std at v1.5.5 (73d44ec) and v4-periphery at 9dafaae, while the git submodule pointers were bumped to v1.9.6 (3b20d60) and the Permissioned Pools commit (363226d). That makes forge print revision mismatch warnings on every build. I synced the two rev entries to the committed submodule revisions; 363226d is on v4-periphery main, so the branch pairing in the lock stays valid.
With both changes, forge build on a fresh checkout compiles with no errors and no dependency warnings.
AI-Generated Description
Summary
Fixes two issues that cause
forge buildto fail or emit warnings on a fresh checkout ofmain.Changes
permissionsAdapterFactory: address(0)field to theRouterParametersstruct constructor, aligning it with the field added in refactor(v4-swap-router): inherit PermissionedV4Router from v4-periphery #476forge-stdrev (73d44ec→3b20d60) andv4-peripheryrev (9dafaae→363226d) to match the committed submodule pointers, eliminating revision-mismatch warningsNotes
permissionsAdapterFactoryis set toaddress(0), which disables permissioned pools — consistent with the pattern used in other deploy scriptsforge buildcompiles cleanly on a fresh clone with no errors or dependency warnings