fix pool init code hash #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PoolAddress library with the updated
POOL_INIT_CODE_HASHconstant is unusable. I assume that while updating v3 periphery libraries to solc 0.8, the pool init code was recompiled and updated to be in sync with the v3-core 0.8 branch, which made the library unusable in any production code that needs to compute pool addresses deployed from existing Uniswap v3 factories (which were deployed with the previous solc version).This PR is reverting the
POOL_INIT_CODE_HASHconstant to the pre-0.8 value that works with all deployed Uniswap v3 factories.