Add per hop slippage checks #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktoda
reviewed
Sep 11, 2025
| amountOut = _swap(poolKey, zeroForOne, -int256(uint256(amountIn)), pathKey.hookData).toUint128(); | ||
|
|
||
| if (perHopSlippageLength != 0) { | ||
| uint256 price = amountIn * PRECISION / amountOut; |
Contributor
There was a problem hiding this comment.
Typically slippage tolerance is in pure amounts rather than ratio - curious why we went with ratio here
Contributor
Author
There was a problem hiding this comment.
this isolates the slippage per hop. If we have two hops and we define a 1% total slippage (in pure amounts) and 0.5% slippage in pure amounts per hop, if the first swap only incurs a 0.1% slippage for example, the second hop could incur up to 0.9% slippage now. But if we have ratio based slippages of 0.5% per hop, regardless of how the first hop performs, the second hop cannot incur more than 0.5% slippage
alanhwu
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.