Skip to content

Conversation

@Bob-six
Copy link
Collaborator

@Bob-six Bob-six commented Jun 29, 2025

Summary by Sourcery

Bug Fixes:

  • Use MEMCACHED_URL env var with fallback to MEMCACHEDCLOUD_SERVERS for Dokku deployments

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 29, 2025

Reviewer's Guide

Modified the MEMCACHED_URL setting to first check a new MEMCACHED_URL environment variable and fall back to MEMCACHEDCLOUD_SERVERS, ensuring compatibility with both Dokku and existing setups.

Class diagram for updated settings environment variable logic

classDiagram
    class settings {
        +DEBUG
        +DATABASE_URL
        +REDIS_URL
        +MEMCACHED_URL
        +MEMCACHED_USERNAME
        +MEMCACHED_PASSWORD
        +DEPLOYMENT_ENV
    }
    settings : MEMCACHED_URL = os.environ.get("MEMCACHED_URL") or os.environ.get("MEMCACHEDCLOUD_SERVERS")
    settings : MEMCACHED_USERNAME = os.environ.get("MEMCACHEDCLOUD_USERNAME")
    settings : MEMCACHED_PASSWORD = os.environ.get("MEMCACHEDCLOUD_PASSWORD")
Loading

File-Level Changes

Change Details Files
Introduce fallback to a new MEMCACHED_URL env var for Memcached settings
  • Changed MEMCACHED_URL assignment to use os.environ.get("MEMCACHED_URL") or os.environ.get("MEMCACHEDCLOUD_SERVERS")
  • Wrapped the fallback in a multi-line expression for readability
  • Removed the previous direct assignment from MEMCACHEDCLOUD_SERVERS
brightIDfaucet/settings.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Bob-six Bob-six merged commit c7ea47b into main Jun 29, 2025
0 of 2 checks passed
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Bob-six - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants