Update type definitions to include custom export#6064
Open
fredrikekelund wants to merge 1 commit intoUnitech:developmentfrom
Open
Update type definitions to include custom export#6064fredrikekelund wants to merge 1 commit intoUnitech:developmentfrom
custom export#6064fredrikekelund wants to merge 1 commit intoUnitech:developmentfrom
Conversation
|
|
fredrikekelund
commented
Dec 3, 2025
Comment on lines
+786
to
+801
| type ProcessStatus = | ||
| | "online" | ||
| | "stopping" | ||
| | "stopped" | ||
| | "launching" | ||
| | "errored" | ||
| | "one-launch-status" | ||
| | "waiting_restart"; | ||
| type Platform = | ||
| | "ubuntu" | ||
| | "centos" | ||
| | "redhat" | ||
| | "gentoo" | ||
| | "systemd" | ||
| | "darwin" | ||
| | "amazon"; |
Author
There was a problem hiding this comment.
Several parts of this diff are just auto-formatting. This is one example.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Exclude whitespace changes when looking at the PR diff to see that I haven't actually changed all that much.
pm2 exports two members in the programmatic interface:
default(an instance ofAPI) andcustom(theAPIclass). However, thecustomprop is not included intypes/index.d.ts.This PR fixes that problem by moving all function definitions inside an
APIclass intypes/index.d.ts. We then use this single definition to declare both thedefaultandcustomexports.I also took the opportunity to update the
starttype definitions to take anErrProcsCallbackas the second parameter (a callback where the second argument isProc[]instead ofProc).