fix: prevent ReDoS vulnerability in regex validation#6091
Open
R-Panic wants to merge 1 commit intoUnitech:masterfrom
Open
fix: prevent ReDoS vulnerability in regex validation#6091R-Panic wants to merge 1 commit intoUnitech:masterfrom
R-Panic wants to merge 1 commit intoUnitech:masterfrom
Conversation
CVE-2025-5891 - Regular Expression Denial of Service vulnerability in lib/tools/Config.js Changes: - Add regex cache to prevent recompilation of patterns - Limit regex input length to 10,000 characters to prevent exponential backtracking - Add try/catch for invalid regex patterns - Prevent ReDoS attacks through config schema validation Fixes Unitech#6086 Signed-off-by: R-Panic <bot@term.com>
|
TermBot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
marcobar324
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE-2025-5891 - Regular Expression Denial of Service vulnerability
Description
This PR fixes a ReDoS vulnerability in the configuration validator where regex patterns could be repeatedly compiled on each validation, and unbounded input strings could cause exponential backtracking attacks.
Changes
Vulnerability Details
Testing
The fix:
Fixes #6086
Signed-off-by: R-Panic bot@term.com