Repository navigation
FIX: [Port] [UUM-160646] Fixed duplicate entries in the binding path search - #2507
Open
josepmariapujol-unity wants to merge 2 commits into
Open
josepmariapujol-unity wants to merge 2 commits into
josepmariapujol-unity wants to merge 2 commits into
Conversation
…search Port of trunk PR #137422. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change consistently applies the existing searchability flag to control-usage entries. I examined the picker tree construction, search filtering, regression test, and changelog, and found no actionable issues.
Reviewed commit 573f145
🤖 Helpful? 👍/👎
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2507 +/- ##
===========================================
+ Coverage 78.96% 79.22% +0.25%
===========================================
Files 767 769 +2
Lines 140949 141283 +334
===========================================
+ Hits 111305 111932 +627
+ Misses 29644 29351 -293 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of trunk PR #137422
Description
Fixes UUM-160646: duplicate entries in the Input Actions Editor binding path search (Binding Properties > Path), for example when searching "mouse".
Some devices appear twice in the control picker tree: Mouse on its own and under Pointer, and XR Controller on its own and under Tracked Device. The nested copy is already excluded from search, but its Usages entries ignored that and stayed searchable. So every usage, for example
<Mouse>/{Back}or<XRController>{LeftHand}/{Menu}, showed up twice in search with the same path.The fix passes the device's
searchableflag throughBuildTreeForControlUsagestoControlUsageDropdownItem, so usage entries under a non-searchable device are non-searchable too.Testing status & QA
CoreTests.Editor_InputControlPicker_SearchDoesNotContainDuplicatePaths: builds the picker tree and checks that no searchable path appears twice. In trunk it fails without the fix and passes with it.Editor_InputControlPicker_TouchscreenPickerContainsSingleAndMultiTouchControlsstill passes in trunk.QA: open an Input Actions asset, select a binding, open the Path picker and search "mouse" or "xr". Each usage entry should appear once.
Overall Product Risks
Comments to reviewers
Search can still show two entries with the same label that are different bindings, for example "Forward [Mouse]" for both the
forwardButtoncontrol and the{Forward}usage. That is out of scope here, as in the trunk PR.The port merged into
developwith no conflicts; the code change is identical to trunk.Description written by Claude Code (Claude Opus 5.5) on behalf of the author.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.