Skip to content

Conversation

@projects-rr
Copy link

Cubemaps & video clips do not currently have their size properly reported.

  • Add Cubemaps to the existing texture data, along with the 'ImageCount' field. Note, the files for this are called Texture2D*, but the databases are texture*, so they seem like the proper place to put all texture types. This code should potentially get updated for other texture types (Texture3D, Texture2DArray, etc...) however I don't have example content to test this with right now.

  • Add video clips to their own database & view

@projects-rr projects-rr force-pushed the report-cubemap-and-videoclip branch from 525d747 to 2dd34ca Compare August 12, 2024 23:08
@xdegtyarev xdegtyarev self-assigned this Feb 18, 2025
@SkowronskiAndrew
Copy link
Collaborator

Thanks for the submission, and sorry for long delay in responding it. The underlying code for adding new types has evolved a bit but adding a table for Video objects makes sense and would be pretty low risk. However it will take a bit of testing and ideally adding a example file with a tiny video inside it for automated test coverage.

I don't know enough about the ins and outs of Textures and how they are serialized to judge if there could be any special concern with adding the image count column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants