Fix: Prevent sourceImpl disposal when multiple receivers are connected #1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prevent disposal of sourceImpl when multiple receivers are connected
Problem
When using
Broadcastmode with multiple WebRTC receivers connected, refreshing one of the receiver pages can trigger a teardown process on the Unity side.During this process, the internal
sourceImpl(e.g.,RenderTextureSourceImpl) ofVideoStreamSenderis disposed, even though other receivers are still actively connected and using the samevideoSender.As a result, subsequent receivers continue streaming, but
videoSenderlacks a valid source, leading to fallback behavior (e.g., screen capture viaCameraVideoSource) or broken stream output.Root Cause
The default logic disposes
sourceImplwhen a transceiver is removed, without checking whether other active transceivers still exist for the same connection.Solution
This fix adds a check before disposing
sourceImpl:This ensures that the video source (e.g., RenderTexture) stays alive as long as there is at least one receiver using it.
Impact
sourceImpllifecycle tied to actual usage instead of per-teardown events.Reproduction Steps (before fix)
Result (after fix)
Refreshing one receiver no longer disrupts video stream for others.
The
sourceImplis only released once all transceivers are properly disposed.