Skip to content

Conversation

@glabute
Copy link
Collaborator

@glabute glabute commented Jul 15, 2025

Purpose of this PR

CMCL-1699. See ticket for repro project.

Resolved an issue where changes to Focal Length and Aperture in CinemachineVolumeSettings were not applied when auto-focus was enabled. The fix ensures these properties are now correctly updated and reflected in the dynamic DepthOfField settings.

Profile assets are not intended to change dynamically, so really this is just a convenience for authoring.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

Resolved an issue where changes to Focal Length and Aperture in CinemachineVolumeSettings were not applied when auto-focus was enabled. The fix ensures these properties are now correctly updated and reflected in the dynamic DepthOfField settings.
@glabute glabute requested a review from alexzaranek July 15, 2025 17:44
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@b8bfaab). Learn more about missing BASE report.
Report is 164 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage        ?   27.27%           
=======================================
  Files           ?      256           
  Lines           ?    28806           
  Branches        ?        0           
=======================================
  Hits            ?     7858           
  Misses          ?    20948           
  Partials        ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@alexzaranek alexzaranek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

@glabute glabute merged commit 529e59a into main Jul 16, 2025
6 of 114 checks passed
@glabute glabute deleted the dev/dynamic-volumesettings-update-for-autofucus branch July 16, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants