Custom blend samples and doc #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 17.19% 17.17% -0.02%
==========================================
Files 209 209
Lines 23705 23702 -3
==========================================
- Hits 4075 4072 -3
Misses 19630 19630
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
glabute
changed the title
Collaborator
sebastienduverne
left a comment
sebastienduverne
left a comment
There was a problem hiding this comment.
First high-level comments just to say I'm aware of that PR to review. I'll actually push an edit of the new doc page at some point. I also plan to review the description and tooltip in the .cs file.
Collaborator
sebastienduverne
left a comment
sebastienduverne
left a comment
There was a problem hiding this comment.
I just committed my edits, please review for accuracy. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
CINE-643: Need doc about how to customize blends
Early LookAt Custom Blend, and cleaned up the implementation.Testing status
Documentation status
[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]
Technical risk
None - just samples and doc