-
Notifications
You must be signed in to change notification settings - Fork 43
iOS open notification settings #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
anjalin14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions, pre-approving.
| ## [Unreleased] | ||
|
|
||
| ### Changes & Improvements: | ||
| - [iOS] iOSNotificationCenter.OpenNotificationSettings will open notifications page for app on iOS 15.4 and newer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [iOS] iOSNotificationCenter.OpenNotificationSettings will open notifications page for app on iOS 15.4 and newer. | |
| - [iOS] iOSNotificationCenter.OpenNotificationSettings now directly opens the notification settings page for your app on iOS 15.4 and later. |
| /// <summary> | ||
| /// Opens Settings. | ||
| /// On iOS there is no way to open notification settings specifically, but you can open settings app with current application settings. | ||
| /// Opens notifications page for this application in the Settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// Opens notifications page for this application in the Settings. | |
| /// Opens the notification settings page for this application in the Settings app. |
| /// Opens Settings. | ||
| /// On iOS there is no way to open notification settings specifically, but you can open settings app with current application settings. | ||
| /// Opens notifications page for this application in the Settings. | ||
| /// Opening notification settings specifically is supported since iOS 15.4. On older versions settings app with current application settings will be opened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// Opening notification settings specifically is supported since iOS 15.4. On older versions settings app with current application settings will be opened. | |
| /// Opening the notification settings directly is supported on iOS 15.4 and later. On earlier versions, this method opens your application settings page in the Settings app. |
| /// On iOS there is no way to open notification settings specifically, but you can open settings app with current application settings. | ||
| /// Opens notifications page for this application in the Settings. | ||
| /// Opening notification settings specifically is supported since iOS 15.4. On older versions settings app with current application settings will be opened. | ||
| /// Note, that application will be suspended, since opening settings is switching to different application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// Note, that application will be suspended, since opening settings is switching to different application. | |
| /// Note that your application suspends as the system switches to the Settings app. |
https://jira.unity3d.com/browse/PLAT-16838
Since iOS 15.4 there is an API to open apps notifications page in settings. Previously opening settings for the application was closest we can get to. Note that the API is marked deprecated in docs, but that marker only applies to Swift, not Objective-C.
The change is trivial "if" to choose one of two URLs to open based on iOS version, no additional testing is required.
The test itself: Main test project has a button to open notification settings. It used to open settings for the app, now, if devices runs iOS 15.4 or later, it will go to notifications page in those settings.